Issue 8872064: Cache the tests across configurations in the test scripts.

Issue 8872064: Cache the tests across configurations in the test scripts. (Closed)

Created:
9 years ago by Mads Ager (google)

Modified:
9 years ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cache the tests across configurations in the test scripts. Only generate the generated tests once and run them for each configuration. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2308

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address review comments. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+131 lines, -82 lines)			Patch
M	tests/stub-generator/test_config.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	tools/testing/dart/multitest.dart	View		7 chunks	+6 lines, -12 lines	0 comments	Download
M	tools/testing/dart/test_runner.dart	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1	11 chunks	+117 lines, -66 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

LGTM. STV! http://codereview.chromium.org/8872064/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): http://codereview.chromium.org/8872064/diff/1/tools/testing/dart/test_suite.dart#newcode13 tools/testing/dart/test_suite.dart:13: void forEachTest(Function onTest, [Function onDone]); Why isn't ...

9 years ago (2011-12-09 13:20:15 UTC) #2

Mads Ager (google)

9 years ago (2011-12-09 13:21:57 UTC) #3

http://codereview.chromium.org/8872064/diff/1/tools/testing/dart/test_suite.dart
File tools/testing/dart/test_suite.dart (right):

http://codereview.chromium.org/8872064/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:13: void forEachTest(Function onTest,
[Function onDone]);
On 2011/12/09 13:20:15, Bill Hesse wrote:
> Why isn't this function signature changed?  Does this pass type checks?

Whoops. Thanks! Done.

http://codereview.chromium.org/8872064/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:184: // We rely on enqueueing completing
asynchroneously so use a
On 2011/12/09 13:20:15, Bill Hesse wrote:
> asynchronously

Done.

http://codereview.chromium.org/8872064/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:244: // errors as negetive.
On 2011/12/09 13:20:15, Bill Hesse wrote:
> negative

Done.

Expand Messages | Collapse Messages