Issue 8872037: Adjust index of type parameters at finalization time (fix issue 718).

Issue 8872037: Adjust index of type parameters at finalization time (fix issue 718). (Closed)

Created:
9 years ago by regis

Modified:
9 years ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Adjust index of type parameters at finalization time (fix issue 718). Add test. Committed: https://code.google.com/p/dart/source/detail?r=2286

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+188 lines, -103 lines)			Patch
M	runtime/lib/error.cc	View		3 chunks	+18 lines, -10 lines	0 comments	Download
M	runtime/vm/class_finalizer.h	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	runtime/vm/class_finalizer.cc	View		13 chunks	+35 lines, -17 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/object.h	View		9 chunks	+19 lines, -21 lines	0 comments	Download
M	runtime/vm/object.cc	View		20 chunks	+46 lines, -35 lines	0 comments	Download
M	runtime/vm/parser.cc	View		7 chunks	+25 lines, -7 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1	4 chunks	+10 lines, -6 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download
A	tests/language/src/Generics2Test.dart	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM http://codereview.chromium.org/8872037/diff/1/runtime/vm/class_finalizer.h File runtime/vm/class_finalizer.h (right): http://codereview.chromium.org/8872037/diff/1/runtime/vm/class_finalizer.h#newcode47 runtime/vm/class_finalizer.h:47: const AbstractType& type, Maybe it would make sense ...

9 years ago (2011-12-08 22:30:29 UTC) #2

regis

9 years ago (2011-12-08 22:50:20 UTC) #3

Thanks

http://codereview.chromium.org/8872037/diff/1/runtime/vm/class_finalizer.h
File runtime/vm/class_finalizer.h (right):

http://codereview.chromium.org/8872037/diff/1/runtime/vm/class_finalizer.h#ne...
runtime/vm/class_finalizer.h:47: const AbstractType& type,
On 2011/12/08 22:30:29, srdjan wrote:
> Maybe it would make sense to have 'type' as first argument?

Not unless we also change ResolveClass, ResolveType,
ResolveAndFinalizeSignature, etc... which all take cls as the first argument.

http://codereview.chromium.org/8872037/diff/1/runtime/vm/class_finalizer.h#ne...
runtime/vm/class_finalizer.h:86: const AbstractType& type);
On 2011/12/08 22:30:29, srdjan wrote:
> ditto

ditto

http://codereview.chromium.org/8872037/diff/1/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (right):

http://codereview.chromium.org/8872037/diff/1/runtime/vm/raw_object.h#newcode284
runtime/vm/raw_object.h:284: 
On 2011/12/08 22:30:29, srdjan wrote:
> private:

Done.

http://codereview.chromium.org/8872037/diff/1/runtime/vm/raw_object.h#newcode291
runtime/vm/raw_object.h:291: class RawType : public RawAbstractType {
On 2011/12/08 22:30:29, srdjan wrote:
> add "private:" (explictly)

Done.

http://codereview.chromium.org/8872037/diff/1/runtime/vm/raw_object.h#newcode331
runtime/vm/raw_object.h:331: class RawAbstractTypeArguments : public RawObject {
Done here too.

Expand Messages | Collapse Messages