Issue 8871001: Thoroughly document html_diff and html_doc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8871001: Thoroughly document html_diff and html_doc. (Closed)

Created:
9 years ago by nweiz

Modified:
9 years ago

Reviewers:
Bob Nystrom, Siggi Cherem (dart-lang), Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Thoroughly document html_diff and html_doc. TBR Committed: https://code.google.com/p/dart/source/detail?r=2204

Patch Set 1 #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+122 lines, -6 lines)			Patch
	M	client/html/scripts/html_diff.dart	View		13 chunks	+102 lines, -4 lines	2 comments	Download
	M	client/html/scripts/html_doc.dart	View		4 chunks	+20 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm Thanks Nathan, very nice. http://codereview.chromium.org/8871001/diff/1/client/html/scripts/html_diff.dart File client/html/scripts/html_diff.dart (right): http://codereview.chromium.org/8871001/diff/1/client/html/scripts/html_diff.dart#newcode385 client/html/scripts/html_diff.dart:385: return _domMembersFromExpression(expr.x, domTypes); I ...

9 years ago (2011-12-07 23:22:18 UTC) #2

nweiz

9 years ago (2011-12-07 23:36:27 UTC) #3

http://codereview.chromium.org/8871001/diff/1/client/html/scripts/html_diff.dart
File client/html/scripts/html_diff.dart (right):

http://codereview.chromium.org/8871001/diff/1/client/html/scripts/html_diff.d...
client/html/scripts/html_diff.dart:385: return _domMembersFromExpression(expr.x,
domTypes);
On 2011/12/07 23:22:18, sigmund wrote:
> I meant to ask you in the prev CL - I was at first surprised to see expr.x
> instead of expr.y, is this because most of the time this is used to detect
> setters (getters are normally within a return expression)?

That's right. The vast majority of the time, when the dart:htmlimpl code is
doing an assignment, it's just wrapping a setter and calling "_ptr.propertyName
= argValue".

Expand Messages | Collapse Messages