Check for using 'this' and 'super'. Tests. Issue 662.

Check for using 'this' and 'super'. Tests. Issue 662.
http://code.google.com/p/dart/issues/detail?id=662


R=zundel@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=2252

[zundel, 2011-12-07 22:11:45]

From our offline conversation;

This fixes problem using 'this' at the top level, which is good.  But the stack
trace in bug 662 seems to indicate that there was a problem in
'visitThisExpression' when this was used in the context of parsing a field.  (I
tried to reproduce this and couldn't)

[zundel, 2011-12-07 23:57:00]

http://codereview.chromium.org/8867001/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java (right):

http://codereview.chromium.org/8867001/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java:39:
libraryElement = unit.getLibrary().getElement();
you don't need this line anymore.

http://codereview.chromium.org/8867001/diff/1/compiler/javatests/com/google/d...
File
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java
(right):

http://codereview.chromium.org/8867001/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java:87:
makeCode("class A {", "  main() {", "    List<int, int> ints = [1];", "  }",
"}"),
I like it better formatted the old way

http://codereview.chromium.org/8867001/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java:110:
"class ClassDeclarationWithLongEnoughNameToForceLineSplitting {}",
do you need the class expression at all in this test?

http://codereview.chromium.org/8867001/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java:118:
"class ClassDeclarationWithLongEnoughNameToForceLineSplitting {}",
do you need the class expression at all?

http://codereview.chromium.org/8867001/diff/1/compiler/javatests/com/google/d...
File compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java
(right):

http://codereview.chromium.org/8867001/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java:65:
// Prepare mock LibraryUnit.
Its only a few lines of code repeated, I know, but you could create a
MockLibraryUnit class to consolidate this initialization from both methods.

LibraryUnit libraryUnit = MockLibraryUnit.create();
LibraryUnit libraryUnit = MockLibraryUnit.create(DartUnit unit); // calls
unit.setLibrary()

[scheglov, 2011-12-08 16:05:15]

http://codereview.chromium.org/8867001/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java (right):

http://codereview.chromium.org/8867001/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java:39:
libraryElement = unit.getLibrary().getElement();
On 2011/12/07 23:57:00, zundel wrote:
> you don't need this line anymore.

Well, almost so.
We still get Scope from libraryElement, so we need it, but not need to assign it
into field.

http://codereview.chromium.org/8867001/diff/1/compiler/javatests/com/google/d...
File
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java
(right):

http://codereview.chromium.org/8867001/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java:87:
makeCode("class A {", "  main() {", "    List<int, int> ints = [1];", "  }",
"}"),
On 2011/12/07 23:57:00, zundel wrote:
> I like it better formatted the old way

Done.

http://codereview.chromium.org/8867001/diff/1/compiler/javatests/com/google/d...
File compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java
(right):

http://codereview.chromium.org/8867001/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java:65:
// Prepare mock LibraryUnit.
On 2011/12/07 23:57:00, zundel wrote:
> Its only a few lines of code repeated, I know, but you could create a
> MockLibraryUnit class to consolidate this initialization from both methods.
> 
> LibraryUnit libraryUnit = MockLibraryUnit.create();
> LibraryUnit libraryUnit = MockLibraryUnit.create(DartUnit unit); // calls
> unit.setLibrary()

Done.

[zundel, 2011-12-08 16:16:14]

lgtm