Issue 8845001: Add --time option to dart test scripts.

Issue 8845001: Add --time option to dart test scripts. (Closed)

Created:
9 years ago by Mads Ager (google)

Modified:
9 years ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add --time option to dart test scripts. This is useful for finding new tests that start taking a long time. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2183

Patch Set 1 #

Patch Set 2 : Long line. #

Patch Set 3 : Runtime test script #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -44 lines)			Patch
M	tools/test.dart	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	tools/test-runtime.dart	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	tools/testing/dart/test_options.dart	View		1 chunk	+8 lines, -1 line	0 comments	Download
M	tools/testing/dart/test_progress.dart	View	1	12 chunks	+58 lines, -40 lines	2 comments	Download
M	tools/testing/dart/test_runner.dart	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

LGTM. The TestCase and TestOutput objects don't look like they will be too big to ...

9 years ago (2011-12-07 16:29:39 UTC) #2

ahe

http://codereview.chromium.org/8845001/diff/4001/tools/testing/dart/test_progress.dart File tools/testing/dart/test_progress.dart (right): http://codereview.chromium.org/8845001/diff/4001/tools/testing/dart/test_progress.dart#newcode250 tools/testing/dart/test_progress.dart:250: : super(startTime, bool printTiming); ../tools/testing/dart/test_progress.dart:242:31: Expected ')', but got ...

9 years ago (2011-12-08 12:17:39 UTC) #3

Mads Ager (google)

9 years ago (2011-12-08 12:22:49 UTC) #4

http://codereview.chromium.org/8845001/diff/4001/tools/testing/dart/test_prog...
File tools/testing/dart/test_progress.dart (right):

http://codereview.chromium.org/8845001/diff/4001/tools/testing/dart/test_prog...
tools/testing/dart/test_progress.dart:250: : super(startTime, bool printTiming);
On 2011/12/08 12:17:39, ahe wrote:
> ../tools/testing/dart/test_progress.dart:242:31: Expected ')', but got
> 'printTiming'
>       : super(startTime, bool printTiming);
>                               ^^^^^^^^^^^

Whoops! Fixed.

Expand Messages | Collapse Messages