Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 8835008: Correctly handle the --arch argument to dart test scripts. (Closed)

Created:
9 years ago by Mads Ager (google)
Modified:
9 years ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Correctly handle the --arch argument to dart test scripts. Support a --verbose/-v flag that prints all commands run. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2169

Patch Set 1 #

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -29 lines) Patch
M tests/stub-generator/test_config.dart View 1 chunk +9 lines, -6 lines 0 comments Download
M tools/test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/test-runtime.dart View 1 2 chunks +4 lines, -2 lines 0 comments Download
M tools/testing/dart/multitest.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/testing/dart/test_options.dart View 6 chunks +24 lines, -9 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 4 chunks +10 lines, -7 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
9 years ago (2011-12-07 10:46:01 UTC) #1
Bill Hesse
lgtm LGTM
9 years ago (2011-12-07 11:15:49 UTC) #2
Bill Hesse
9 years ago (2011-12-07 11:15:50 UTC) #3
lgtm

LGTM

Powered by Google App Engine
This is Rietveld 408576698