Issue 8832008: Make test scripts work on Windows again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8832008: Make test scripts work on Windows again. (Closed)

Created:
9 years ago by Mads Ager (google)

Modified:
9 years ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make test scripts work on Windows again. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2177

Patch Set 2 : Address comments. #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	tools/testing/dart/multitest.dart	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

LGTM. http://codereview.chromium.org/8832008/diff/1/tools/testing/dart/multitest.dart File tools/testing/dart/multitest.dart (right): http://codereview.chromium.org/8832008/diff/1/tools/testing/dart/multitest.dart#newcode208 tools/testing/dart/multitest.dart:208: String path = parentDir.path + split.last(); We may ...

9 years ago (2011-12-07 14:36:49 UTC) #2

Mads Ager (google)

9 years ago (2011-12-07 14:40:46 UTC) #3

http://codereview.chromium.org/8832008/diff/1/tools/testing/dart/multitest.dart
File tools/testing/dart/multitest.dart (right):

http://codereview.chromium.org/8832008/diff/1/tools/testing/dart/multitest.da...
tools/testing/dart/multitest.dart:208: String path = parentDir.path +
split.last();
On 2011/12/07 14:36:54, Bill Hesse wrote:
> We may need to put a / between the two components here.  Check this.

We do need that. Thanks!

Expand Messages | Collapse Messages

Issue 8832008: Make test scripts work on Windows again. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comments. #

Messages