Issue 8828008: Modification to the order that classes are printed out so that the prototype

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8828008: Modification to the order that classes are printed out so that the prototype (Closed)

Created:
9 years ago by Emily Fortuna

Modified:
9 years ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Modification to the order that classes are printed out so that the prototype class is always printed out before the inheriting class. Adjustments to make the benchmarks run in IE9. Committed: https://code.google.com/p/dart/source/detail?r=2271

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 3

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+399 lines, -266 lines)			Patch
M	frog/gen.dart	View	1 2 3	3 chunks	+34 lines, -23 lines	0 comments	Download
M	frog/minfrog	View	1 2 3	161 chunks	+246 lines, -240 lines	0 comments	Download
A	frog/tests/frog/src/InheritanceOrderingTest.dart	View	1	1 chunk	+111 lines, -0 lines	0 comments	Download
M	frog/type.dart	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/testing/perf_testing/create_graph.py	View	1 2 3	4 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

9 years ago (2011-12-08 18:43:52 UTC) #2

lgtm

http://codereview.chromium.org/8828008/diff/2001/frog/gen.dart
File frog/gen.dart (right):

http://codereview.chromium.org/8828008/diff/2001/frog/gen.dart#newcode235
frog/gen.dart:235: // IE.
might want to add a note that this is for the $inherits implementation, when we
don't have __proto__ available

http://codereview.chromium.org/8828008/diff/2001/frog/gen.dart#newcode236
frog/gen.dart:236: if (type.parent !=  null && !type.isNative)
style nit: add { } around the body unless the entire "if" is on one line

http://codereview.chromium.org/8828008/diff/2001/frog/gen.dart#newcode258
frog/gen.dart:258: if (!type.isTop) {
maybe add a note here that $inherits needs to come immediately after the JS
constructor function is declared?

Expand Messages | Collapse Messages