Issue 8827016: Add a flags field to RawObject so that we can tag objects with certain

Issue 8827016: Add a flags field to RawObject so that we can tag objects with certain (Closed)

Created:
9 years ago by siva

Modified:
9 years ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Add a tags field to RawObject so that we can tag objects with certain values, e.g: - object is canonical - object was created from snapshot etc. Once we have class Ids implemented the current class_ and flags_ words can be compressed into a single header word. Committed: https://code.google.com/p/dart/source/detail?r=2211

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -16 lines)			Patch
M	tests/vm/vm.status	View	1 2	1 chunk	+0 lines, -4 lines	0 comments	Download
M	vm/dart_api_impl_test.cc	View	1 2	2 chunks	+6 lines, -4 lines	0 comments	Download
M	vm/object.h	View	1 2	3 chunks	+4 lines, -2 lines	0 comments	Download
M	vm/object.cc	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	vm/object_test.cc	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download
M	vm/raw_object.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	vm/stub_code_ia32.cc	View	1 2	8 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with proper loop condition. -Ivan http://codereview.chromium.org/8827016/diff/5001/vm/stub_code_ia32.cc File vm/stub_code_ia32.cc (right): http://codereview.chromium.org/8827016/diff/5001/vm/stub_code_ia32.cc#newcode1188 vm/stub_code_ia32.cc:1188: __ j(GREATER_EQUAL, &init_loop, ...

9 years ago (2011-12-08 00:13:22 UTC) #2

siva

http://codereview.chromium.org/8827016/diff/5001/vm/stub_code_ia32.cc File vm/stub_code_ia32.cc (right): http://codereview.chromium.org/8827016/diff/5001/vm/stub_code_ia32.cc#newcode1188 vm/stub_code_ia32.cc:1188: __ j(GREATER_EQUAL, &init_loop, Assembler::kNearJump); On 2011/12/08 00:13:22, Ivan Posva ...

9 years ago (2011-12-08 00:42:37 UTC) #3

srdjan

9 years ago (2011-12-09 17:21:49 UTC) #4

This CL caused large performance degradation: http://nobel.aar/dart/r2211.html
(Mandelbrot and NBody, floating point benchmarks, 30% degradation).

Could you please investigate/fix? Is the alignment of doubles in new generation
now suboptimal?

On 2011/12/08 00:42:37, asiva wrote:
> http://codereview.chromium.org/8827016/diff/5001/vm/stub_code_ia32.cc
> File vm/stub_code_ia32.cc (right):
> 
>
http://codereview.chromium.org/8827016/diff/5001/vm/stub_code_ia32.cc#newcode...
> vm/stub_code_ia32.cc:1188: __ j(GREATER_EQUAL, &init_loop,
> Assembler::kNearJump);
> On 2011/12/08 00:13:22, Ivan Posva wrote:
> > Not the correct check.
> 
> Done.

Expand Messages | Collapse Messages