Issue 8826014: frog: generalize checking that type args aren't used in static methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8826014: frog: generalize checking that type args aren't used in static methods (Closed)

Created:
9 years ago by Siggi Cherem (dart-lang)

Modified:
9 years ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

frog: generalize checking that type args aren't used in static methods Committed: https://code.google.com/p/dart/source/detail?r=2157

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -23 lines)			Patch
M	frog/gen.dart	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	frog/member.dart	View	2 chunks	+10 lines, -4 lines	0 comments	Download
M	frog/minfrog	View	3 chunks	+11 lines, -8 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

Siggi Cherem (dart-lang)

turns out the boolean argument to resolveType is not only used for indicating that we ...

9 years ago (2011-12-07 00:47:27 UTC) #1

lgtm! very clean, +5 tests passing, what's not to like