Issue 8822001: Bunch of dartdoc changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8822001: Bunch of dartdoc changes. (Closed)

Created:
9 years ago by Bob Nystrom

Modified:
9 years ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Bunch of dartdoc changes: - Add special fake entrypoints so you can build docs for just corelib, dom, or html. - Better main index page. - Only show classes in nav for current library. - Link to index page. - Fix word wrap on icons. - Sort case-insensitively. Committed: https://code.google.com/p/dart/source/detail?r=2143

Patch Set 1 #

Total comments: 4

Patch Set 2 : Respond to review. #

Patch Set 3 : Default to showing source. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -68 lines)			Patch
M	utils/dartdoc/dartdoc	View	1	1 chunk	+14 lines, -1 line	0 comments	Download
M	utils/dartdoc/dartdoc.dart	View	1 2	9 chunks	+79 lines, -64 lines	0 comments	Download
M	utils/dartdoc/interact.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	utils/dartdoc/static/styles.css	View		4 chunks	+5 lines, -3 lines	0 comments	Download
M	utils/dartdoc/utils.dart	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm http://codereview.chromium.org/8822001/diff/1/utils/dartdoc/dartdoc File utils/dartdoc/dartdoc (right): http://codereview.chromium.org/8822001/diff/1/utils/dartdoc/dartdoc#newcode19 utils/dartdoc/dartdoc:19: if [[ $1 == *.txt ]] .txt? should ...

9 years ago (2011-12-06 17:29:57 UTC) #2

Bob Nystrom

9 years ago (2011-12-06 19:25:05 UTC) #3

Thanks!

http://codereview.chromium.org/8822001/diff/1/utils/dartdoc/dartdoc
File utils/dartdoc/dartdoc (right):

http://codereview.chromium.org/8822001/diff/1/utils/dartdoc/dartdoc#newcode19
utils/dartdoc/dartdoc:19: if [[ $1 == *.txt ]]
On 2011/12/06 17:29:57, sigmund wrote:
> .txt? should it be .dart?

<facepalm>

Thanks.

http://codereview.chromium.org/8822001/diff/1/utils/dartdoc/dartdoc.dart
File utils/dartdoc/dartdoc.dart (right):

http://codereview.chromium.org/8822001/diff/1/utils/dartdoc/dartdoc.dart#newc...
utils/dartdoc/dartdoc.dart:99: case 'corelib':
On 2011/12/06 17:29:57, sigmund wrote:
> +2 >> (indentation seems odd for the body of the switch)

Done.

Expand Messages | Collapse Messages