Work-around for FireFox: patch non-leaf types statically if possible.

Work-around for FireFox: patch non-leaf types statically if possible.


BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=2114

[sra1, 2011-12-06 03:41:49]

tbr

[Emily Fortuna, 2011-12-06 18:19:35]

http://codereview.chromium.org/8820004/diff/1/client/dom/generated/src/frog/N...
File client/dom/generated/src/frog/Node.dart (left):

http://codereview.chromium.org/8820004/diff/1/client/dom/generated/src/frog/N...
client/dom/generated/src/frog/Node.dart:2: class Node native "*Node" {
Just so I  fully understand what's going on here, what did the * previously
signify?

http://codereview.chromium.org/8820004/diff/1/client/dom/scripts/dartgenerato...
File client/dom/scripts/dartgenerator.py (right):

http://codereview.chromium.org/8820004/diff/1/client/dom/scripts/dartgenerato...
client/dom/scripts/dartgenerator.py:1014: def _StartGenerateFrogImpl(self,
database, output_dir):
Why pass database around if we can access it as self._database?

[sra1, 2011-12-06 19:25:30]

http://codereview.chromium.org/8820004/diff/1/client/dom/generated/src/frog/N...
File client/dom/generated/src/frog/Node.dart (left):

http://codereview.chromium.org/8820004/diff/1/client/dom/generated/src/frog/N...
client/dom/generated/src/frog/Node.dart:2: class Node native "*Node" {
On 2011/12/06 18:19:35, Emily Fortuna wrote:
> Just so I  fully understand what's going on here, what did the * previously
> signify?

See frog/type.dart
/**
 * Information about a native type from the native string.
 *
 *  "Foo"  - constructor function is called 'Foo'.
 *  "=Foo" - a singleton instance that should be patched directly. For example,
 *           "=window.console"
 *  "*Foo" - name is 'Foo', constructor function and prototype are not available
 *      in global scope during initialization.  This is characteristic of many
 *      DOM types like CanvasPixelArray. However, the *type name* is presumed to
 *      be available at runtime from the prototype.
 *  "@Foo" - the type of the global object. Members will be treated as names
 *      that can't be shadowed in generated JS.
 */
// TODO(jmesserly): we really need a richer annotation system than just encoding
// this data in strings with magic characters.
class NativeType {

http://codereview.chromium.org/8820004/diff/1/client/dom/scripts/dartgenerato...
File client/dom/scripts/dartgenerator.py (right):

http://codereview.chromium.org/8820004/diff/1/client/dom/scripts/dartgenerato...
client/dom/scripts/dartgenerator.py:1014: def _StartGenerateFrogImpl(self,
database, output_dir):
On 2011/12/06 18:19:35, Emily Fortuna wrote:
> Why pass database around if we can access it as self._database?

Good point.  Other code does this, so I'm copying that pattern.
I can fix this when I do subsequent work.

[Emily Fortuna, 2011-12-06 19:27:46]

lgtm