Create the SDK in a temporary directory and copy it as a final step.

Create the SDK in a temporary directory and copy it as a final step.
Committed: https://code.google.com/p/dart/source/detail?r=2137

[Siggi Cherem (dart-lang), 2011-12-06 18:58:42]

lgtm

http://codereview.chromium.org/8819030/diff/1/tools/create_sdk.py
File tools/create_sdk.py (right):

http://codereview.chromium.org/8819030/diff/1/tools/create_sdk.py#newcode360
tools/create_sdk.py:360: UTIL = join(SDK_tmp, 'tools')
UTILS -> TOOLS or 'tools' -> 'utils'?

[ahe, 2011-12-07 11:23:29]

LGTM

http://codereview.chromium.org/8819030/diff/7001/tools/create_sdk.py
File tools/create_sdk.py (right):

http://codereview.chromium.org/8819030/diff/7001/tools/create_sdk.py#newcode366
tools/create_sdk.py:366: copytree(SDK_tmp, SDK)
Have you considered this approach (in shell script pseudo code):

rm -rf $SDK
rm -rf ${SDK}.tmp
mkdir ${SDK}.tmp
put everything in ${SDK}.tmp
mv ${SDK}.tmp $SDK

The downside to the current approach is that it is twice as slow.

[ahe, 2011-12-07 11:25:11]

http://codereview.chromium.org/8819030/diff/7001/tools/create_sdk.py
File tools/create_sdk.py (right):

http://codereview.chromium.org/8819030/diff/7001/tools/create_sdk.py#newcode366
tools/create_sdk.py:366: copytree(SDK_tmp, SDK)
On 2011/12/07 11:23:29, ahe wrote:
> Have you considered this approach (in shell script pseudo code):
> 
> rm -rf $SDK
> rm -rf ${SDK}.tmp
> mkdir ${SDK}.tmp
> put everything in ${SDK}.tmp
> mv ${SDK}.tmp $SDK
> 
> The downside to the current approach is that it is twice as slow.

Actually, there is another downside to the current approach. You cannot
interrupt the build safely. If I hit Ctrl-C while copytree is running, I get a
broken build.