Issue 8819021: Simulate data and close callbacks on a synchronous file input stream

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8819021: Simulate data and close callbacks on a synchronous file input stream (Closed)

Created:
9 years ago by Søren Gjesse

Modified:
9 years ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Simulate data and close callbacks on a synchronous file input stream A input stream obtained from File.openInputStream() can now be used with code that expects data and close callbacks. Before the input stream obtained from File.openInputStream() did not generate any callbacks. R=ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2166

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -10 lines)			Patch
	M	runtime/bin/file_impl.dart	View		2 chunks	+54 lines, -7 lines	0 comments	Download
	M	tests/standalone/src/FileInputStreamTest.dart	View	1	3 chunks	+61 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

9 years ago (2011-12-06 15:16:37 UTC) #2

lgtm

http://codereview.chromium.org/8819021/diff/1/runtime/bin/file_impl.dart
File runtime/bin/file_impl.dart (right):

http://codereview.chromium.org/8819021/diff/1/runtime/bin/file_impl.dart#newc...
runtime/bin/file_impl.dart:93: // a new callback if the previous one have
actually been called.
have ->  has

Expand Messages | Collapse Messages