Add chunked input stream

Add chunked input stream

The chunked input stream can deliver data fron an input stream as
fixed sized blocks of data.

R=ager@google.com

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=2163

[Mads Ager (google), 2011-12-06 14:05:01]

lgtm

http://codereview.chromium.org/8818009/diff/3001/runtime/bin/buffer_list.dart
File runtime/bin/buffer_list.dart (right):

http://codereview.chromium.org/8818009/diff/3001/runtime/bin/buffer_list.dart...
runtime/bin/buffer_list.dart:57: /*
Do you want to use DartDoc style here: '/**'?

Half of the methods here seem to have DartDoc style comments and the rest do
not.

http://codereview.chromium.org/8818009/diff/3001/runtime/bin/chunked_stream.dart
File runtime/bin/chunked_stream.dart (right):

http://codereview.chromium.org/8818009/diff/3001/runtime/bin/chunked_stream.d...
runtime/bin/chunked_stream.dart:7: : _chunkSize = chunkSize, _bufferList = new 
_BufferList() {
Remove one of the spaces after 'new'?

http://codereview.chromium.org/8818009/diff/3001/runtime/bin/chunked_stream.d...
runtime/bin/chunked_stream.dart:98: void issueCloseCallback(Timer timer) {
We should remove the Timer argument from Timer callbacks. I don't see any use
for it at all. We can do that in another change.

http://codereview.chromium.org/8818009/diff/3001/runtime/bin/chunked_stream.d...
runtime/bin/chunked_stream.dart:112: // Schedule close callback if no more data
and input is closed..
Remove extra period.

http://codereview.chromium.org/8818009/diff/3001/runtime/bin/input_stream.dart
File runtime/bin/input_stream.dart (right):

http://codereview.chromium.org/8818009/diff/3001/runtime/bin/input_stream.dar...
runtime/bin/input_stream.dart:120: * Decodes a binary input stream into
characters using the specified
This looks like a copied comment. ;-)

http://codereview.chromium.org/8818009/diff/3001/tests/standalone/src/Chunked...
File tests/standalone/src/ChunkedStreamTest.dart (right):

http://codereview.chromium.org/8818009/diff/3001/tests/standalone/src/Chunked...
tests/standalone/src/ChunkedStreamTest.dart:91: var _16k = 1024 * 16;
Is the underscore needed here?

http://codereview.chromium.org/8818009/diff/3001/tests/standalone/src/Chunked...
tests/standalone/src/ChunkedStreamTest.dart:115: chunk = stream.read();
Maybe add comments here static how many bytes are expected to be in the stream
at each point? Here it is 7.

http://codereview.chromium.org/8818009/diff/3001/tests/standalone/src/Chunked...
tests/standalone/src/ChunkedStreamTest.dart:156: 
It would be nice to also have a test that changes the chunkSize in the
dataHandler. Potentially just an extra stage above.

[Søren Gjesse, 2011-12-07 07:58:29]

http://codereview.chromium.org/8818009/diff/3001/runtime/bin/buffer_list.dart
File runtime/bin/buffer_list.dart (right):

http://codereview.chromium.org/8818009/diff/3001/runtime/bin/buffer_list.dart...
runtime/bin/buffer_list.dart:57: /*
On 2011/12/06 14:05:02, Mads Ager wrote:
> Do you want to use DartDoc style here: '/**'?
> 
> Half of the methods here seem to have DartDoc style comments and the rest do
> not.

I am not realy sure. This is an internal class. Made them all DartDoc style for
now.

http://codereview.chromium.org/8818009/diff/3001/runtime/bin/chunked_stream.dart
File runtime/bin/chunked_stream.dart (right):

http://codereview.chromium.org/8818009/diff/3001/runtime/bin/chunked_stream.d...
runtime/bin/chunked_stream.dart:7: : _chunkSize = chunkSize, _bufferList = new 
_BufferList() {
On 2011/12/06 14:05:02, Mads Ager wrote:
> Remove one of the spaces after 'new'?

Done.

http://codereview.chromium.org/8818009/diff/3001/runtime/bin/chunked_stream.d...
runtime/bin/chunked_stream.dart:98: void issueCloseCallback(Timer timer) {
On 2011/12/06 14:05:02, Mads Ager wrote:
> We should remove the Timer argument from Timer callbacks. I don't see any use
> for it at all. We can do that in another change.

OK

http://codereview.chromium.org/8818009/diff/3001/runtime/bin/chunked_stream.d...
runtime/bin/chunked_stream.dart:112: // Schedule close callback if no more data
and input is closed..
On 2011/12/06 14:05:02, Mads Ager wrote:
> Remove extra period.

Done.

http://codereview.chromium.org/8818009/diff/3001/runtime/bin/input_stream.dart
File runtime/bin/input_stream.dart (right):

http://codereview.chromium.org/8818009/diff/3001/runtime/bin/input_stream.dar...
runtime/bin/input_stream.dart:120: * Decodes a binary input stream into
characters using the specified
On 2011/12/06 14:05:02, Mads Ager wrote:
> This looks like a copied comment. ;-)

Done.

http://codereview.chromium.org/8818009/diff/3001/tests/standalone/src/Chunked...
File tests/standalone/src/ChunkedStreamTest.dart (right):

http://codereview.chromium.org/8818009/diff/3001/tests/standalone/src/Chunked...
tests/standalone/src/ChunkedStreamTest.dart:91: var _16k = 1024 * 16;
On 2011/12/06 14:05:02, Mads Ager wrote:
> Is the underscore needed here?

Yes, a variable cannot start with a digit.

http://codereview.chromium.org/8818009/diff/3001/tests/standalone/src/Chunked...
tests/standalone/src/ChunkedStreamTest.dart:115: chunk = stream.read();
On 2011/12/06 14:05:02, Mads Ager wrote:
> Maybe add comments here static how many bytes are expected to be in the stream
> at each point? Here it is 7.

Done.

http://codereview.chromium.org/8818009/diff/3001/tests/standalone/src/Chunked...
tests/standalone/src/ChunkedStreamTest.dart:156: 
On 2011/12/06 14:05:02, Mads Ager wrote:
> It would be nice to also have a test that changes the chunkSize in the
> dataHandler. Potentially just an extra stage above.

Good point. Done.