Issue 8817025: Enable test script to specify different DRT binary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8817025: Enable test script to specify different DRT binary (Closed)

Created:
9 years ago by vsm

Modified:
9 years ago

Reviewers:
Emily Fortuna, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Enable test script to specify different DRT binary Committed: https://code.google.com/p/dart/source/detail?r=2144

Patch Set 1 #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -6 lines)			Patch
	M	tools/testing/architecture.py	View		1 chunk	+16 lines, -6 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

9 years ago (2011-12-06 19:08:18 UTC) #3

lgtm, also minor question below

http://codereview.chromium.org/8817025/diff/1/tools/testing/architecture.py
File tools/testing/architecture.py (right):

http://codereview.chromium.org/8817025/diff/1/tools/testing/architecture.py#n...
tools/testing/architecture.py:293: dart_flags += ' '.join(flags)
Out of curiosity, why rename vm_options to the local variable flags? It doesn't
look like either are being modified and "flags" is only used twice.

Expand Messages | Collapse Messages