Issue 8817020: Fixes for JUnit tests

Issue 8817020: Fixes for JUnit tests (Closed)

Created:
9 years ago by scheglov

Modified:
9 years ago

Reviewers:
zundel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixes for JUnit tests R=zundel@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2188

Patch Set 1 #

Total comments: 3

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -58 lines)			Patch
M	compiler/javatests/com/google/dart/compiler/backend/js/ExprOptTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/backend/js/JsConstExprOptTest.java	View	1 chunk	+2 lines, -15 lines	1 comment	Download
M	compiler/javatests/com/google/dart/compiler/backend/js/JsConstructorOptTest.java	View	5 chunks	+17 lines, -15 lines	1 comment	Download
M	compiler/javatests/com/google/dart/compiler/backend/js/RttTest.java	View	3 chunks	+6 lines, -6 lines	1 comment	Download
M	compiler/javatests/com/google/dart/compiler/backend/js/SnippetTestCase.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/backend/js/testConstantExprOpt.dart	View	2 chunks	+4 lines, -10 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTestCase.java	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	compiler/javatests/com/google/dart/corelib/SharedTestCase.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zundel

9 years ago (2011-12-07 15:58:57 UTC) #2

LGTM, but make sure these tests are executed from a test suite.

http://codereview.chromium.org/8817020/diff/1/compiler/javatests/com/google/d...
File
compiler/javatests/com/google/dart/compiler/backend/js/JsConstExprOptTest.java
(right):

http://codereview.chromium.org/8817020/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/backend/js/JsConstExprOptTest.java:12:
public class JsConstExprOptTest extends ExprOptTest {
add this test to JsBackendTests so it will run from command line unit tests.

http://codereview.chromium.org/8817020/diff/1/compiler/javatests/com/google/d...
File
compiler/javatests/com/google/dart/compiler/backend/js/JsConstructorOptTest.java
(right):

http://codereview.chromium.org/8817020/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/backend/js/JsConstructorOptTest.java:12:
public class JsConstructorOptTest extends ExprOptTest {
add this test to JsBackendTests so it will run from command line unit tests.

http://codereview.chromium.org/8817020/diff/1/compiler/javatests/com/google/d...
File compiler/javatests/com/google/dart/compiler/backend/js/RttTest.java
(right):

http://codereview.chromium.org/8817020/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/backend/js/RttTest.java:12: public
class RttTest extends SnippetTestCase {
add this test to JsBackendTests so it will run from command line unit tests.

Expand Messages | Collapse Messages