Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 8817017: Support actual stub generation in the dart test scripts. (Closed)

Created:
9 years ago by Mads Ager (google)
Modified:
9 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support actual stub generation in the dart test scripts. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2120

Patch Set 1 #

Patch Set 2 : Line length #

Patch Set 3 : Adding line #

Total comments: 2

Patch Set 4 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -28 lines) Patch
M tests/stub-generator/test_config.dart View 1 2 3 1 chunk +104 lines, -5 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 2 3 5 chunks +34 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mads Ager (google)
This is pretty nasty. It generates the file on top of the file that is ...
9 years ago (2011-12-06 13:08:44 UTC) #1
Søren Gjesse
lgtm http://codereview.chromium.org/8817017/diff/2002/tests/stub-generator/test_config.dart File tests/stub-generator/test_config.dart (right): http://codereview.chromium.org/8817017/diff/2002/tests/stub-generator/test_config.dart#newcode78 tests/stub-generator/test_config.dart:78: ++activeTestGenerators; Should there be a method for this ...
9 years ago (2011-12-06 13:35:32 UTC) #2
Mads Ager (google)
http://codereview.chromium.org/8817017/diff/2002/tests/stub-generator/test_config.dart File tests/stub-generator/test_config.dart (right): http://codereview.chromium.org/8817017/diff/2002/tests/stub-generator/test_config.dart#newcode78 tests/stub-generator/test_config.dart:78: ++activeTestGenerators; On 2011/12/06 13:35:32, Søren Gjesse wrote: > Should ...
9 years ago (2011-12-06 13:39:31 UTC) #3
Bill Hesse
9 years ago (2011-12-06 13:54:30 UTC) #4
lgtm.

Powered by Google App Engine
This is Rietveld 408576698