Issue 8805008: Various scanner fixes:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8805008: Various scanner fixes: (Closed)

Created:
9 years ago by ahe

Modified:
9 years ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, karlklose, kasperl, Lasse Reichstein Nielsen, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Various scanner fixes: * tokenize string interpolation * handle 1.toString() and 2.dynamic better * don't group <> across semicolon * tokenize keywords that is a prefix of another keyword. Committed: https://code.google.com/p/dart/source/detail?r=2068

Patch Set 1 : changes #

Patch Set 2 : Rebased and update language.status #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+150 lines, -54 lines)			Patch
M	dart/frog/leg/scanner/array_based_scanner.dart	View		3 chunks	+34 lines, -15 lines	0 comments	Download
M	dart/frog/leg/scanner/byte_array_scanner.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	dart/frog/leg/scanner/characters.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	dart/frog/leg/scanner/keyword.dart	View		5 chunks	+21 lines, -8 lines	0 comments	Download
M	dart/frog/leg/scanner/scanner.dart	View		17 chunks	+45 lines, -18 lines	0 comments	Download
M	dart/frog/leg/scanner/string_scanner.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	dart/frog/leg/scanner/token.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	dart/frog/leg/tools/mini_parser.dart	View		2 chunks	+44 lines, -7 lines	0 comments	Download
M	dart/tests/language/language.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages