Issue 8803027: Upload SDK builds to gs://dartium-archive . This step will only

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8803027: Upload SDK builds to gs://dartium-archive . This step will only (Closed)

Created:
9 years ago by dgrove

Modified:
9 years ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Upload SDK builds to gs://dartium-archive . This step will only happen on buildbots. Committed: https://code.google.com/p/dart/source/detail?r=2106

Patch Set 3 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -0 lines)			Patch
	M	dart.gyp	View		1 chunk	+24 lines, -0 lines	0 comments	Download
	A	tools/upload_sdk.py	View	1 2	1 chunk	+74 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm w some minor comments http://codereview.chromium.org/8803027/diff/1/tools/upload_sdk.py File tools/upload_sdk.py (right): http://codereview.chromium.org/8803027/diff/1/tools/upload_sdk.py#newcode7 tools/upload_sdk.py:7: (nit) add top-level comment ...

9 years ago (2011-12-06 00:26:38 UTC) #2

dgrove

9 years ago (2011-12-06 00:40:23 UTC) #3

http://codereview.chromium.org/8803027/diff/1/tools/upload_sdk.py
File tools/upload_sdk.py (right):

http://codereview.chromium.org/8803027/diff/1/tools/upload_sdk.py#newcode7
tools/upload_sdk.py:7: 
On 2011/12/06 00:26:39, sigmund wrote:
> (nit) add top-level comment saying what this file is doing, and describing
> expected arguments

Done.

http://codereview.chromium.org/8803027/diff/1/tools/upload_sdk.py#newcode55
tools/upload_sdk.py:55: exit(0)
On 2011/12/06 00:26:39, sigmund wrote:
> return 1? - some usage message?

Done.

http://codereview.chromium.org/8803027/diff/1/tools/upload_sdk.py#newcode59
tools/upload_sdk.py:59: exit(0)
On 2011/12/06 00:26:39, sigmund wrote:
> return 1

Done.

Expand Messages | Collapse Messages

Issue 8803027: Upload SDK builds to gs://dartium-archive . This step will only (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages