Issue 8802028: fix set index bug in frog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8802028: fix set index bug in frog. (Closed)

Created:
9 years ago by Siggi Cherem (dart-lang)

Modified:
9 years ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

fix set index bug in frog. BUG= http://code.google.com/p/dart/issues/detail?id=541 Committed: https://code.google.com/p/dart/source/detail?r=2108

Patch Set 1 #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -14 lines)			Patch
M	frog/gen.dart	View	7 chunks	+21 lines, -5 lines	1 comment	Download
M	frog/minfrog	View	11 chunks	+28 lines, -8 lines	0 comments	Download
M	tests/corelib/corelib.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

9 years ago (2011-12-06 01:06:38 UTC) #2

lgtm

http://codereview.chromium.org/8802028/diff/1/frog/gen.dart
File frog/gen.dart (right):

http://codereview.chromium.org/8802028/diff/1/frog/gen.dart#newcode1182
frog/gen.dart:1182: var value = visitBinaryExpression(node, /*isVoid:*/true);
you could actually pass "isVoid:true" now :)

Expand Messages | Collapse Messages