Issue 8799018: Fixed lambdas that have the same name as one of their parameters/locals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8799018: Fixed lambdas that have the same name as one of their parameters/locals (Closed)

Created:
9 years ago by Jennifer Messerly

Modified:
9 years ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, sra1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixed lambdas that have the same name as one of their parameters/locals It even fixed a corelib test :) http://code.google.com/p/dart/issues/detail?id=388 Committed: https://code.google.com/p/dart/source/detail?r=2100

Patch Set 1 #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -33 lines)			Patch
M	frog/gen.dart	View	4 chunks	+17 lines, -19 lines	2 comments	Download
M	frog/minfrog	View	4 chunks	+11 lines, -13 lines	0 comments	Download
M	tests/corelib/corelib.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

tbr http://codereview.chromium.org/8799018/diff/1/frog/gen.dart File frog/gen.dart (left): http://codereview.chromium.org/8799018/diff/1/frog/gen.dart#oldcode1239 frog/gen.dart:1239: var name = world.toJsIdentifier(node.name.name); MethodMember "jsname" handles this ...

9 years ago (2011-12-05 23:05:10 UTC) #1

lgtm

Expand Messages | Collapse Messages