Issue 8799009: Add support for client/dartc compilation only tests.

Issue 8799009: Add support for client/dartc compilation only tests. (Closed)

Created:
9 years ago by Mads Ager (google)

Modified:
9 years ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add support for client/dartc compilation only tests. These tests do not fit in that nicely. They have an interesting way of finding out what are test cases. They use the .dart suffix in the status file. Implement directory createTempSync. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2067

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+154 lines, -30 lines)			Patch
M	client/tests/dartc/dartc.status	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/builtin_natives.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/directory.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/directory.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	runtime/bin/directory_impl.dart	View		3 chunks	+12 lines, -3 lines	0 comments	Download
M	tests/standalone/src/DirectoryTest.dart	View	1	1 chunk	+36 lines, -10 lines	0 comments	Download
M	tools/test.dart	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	tools/testing/dart/test_options.dart	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View		8 chunks	+82 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

LGTM. http://codereview.chromium.org/8799009/diff/1/tests/standalone/src/DirectoryTest.dart File tests/standalone/src/DirectoryTest.dart (right): http://codereview.chromium.org/8799009/diff/1/tests/standalone/src/DirectoryTest.dart#newcode12 tests/standalone/src/DirectoryTest.dart:12: Directory directory = new Directory("/tmp/dart_temp_dir_"); Surely this won't ...

9 years ago (2011-12-05 13:21:39 UTC) #2

Mads Ager (google)

9 years ago (2011-12-05 13:32:01 UTC) #3

http://codereview.chromium.org/8799009/diff/1/tests/standalone/src/DirectoryT...
File tests/standalone/src/DirectoryTest.dart (right):

http://codereview.chromium.org/8799009/diff/1/tests/standalone/src/DirectoryT...
tests/standalone/src/DirectoryTest.dart:12: Directory directory = new
Directory("/tmp/dart_temp_dir_");
On 2011/12/05 13:21:39, Bill Hesse wrote:
> Surely this won't work on Windows, will it?  Unless there happens to be a /tmp
> directory on the Windows drive?

Thanks. I'll just use an empty string. I was copying it from below and didn't
realize that there is a test that '/tmp' exists. :)

Expand Messages | Collapse Messages