- Add free list to be used for sweep phase of mark-sweep collector.

- Add free list to be used for sweep phase of mark-sweep collector.
Committed: https://code.google.com/p/dart/source/detail?r=2053

[Ivan Posva, 2011-12-03 05:39:17]

TBR=asiva

[antonm, 2011-12-15 10:00:25]

DBC

http://codereview.chromium.org/8787012/diff/5001/vm/dart.cc
File vm/dart.cc (right):

http://codereview.chromium.org/8787012/diff/5001/vm/dart.cc#newcode8
vm/dart.cc:8: #include "vm/freelist.h"
nit: sorting

http://codereview.chromium.org/8787012/diff/5001/vm/freelist.cc
File vm/freelist.cc (right):

http://codereview.chromium.org/8787012/diff/5001/vm/freelist.cc#newcode21
vm/freelist.cc:21: reinterpret_cast<RawClass*>(calloc(1,
Class::InstanceSize()));
maybe should check the alignment of allocated data?  or allocate with the proper
alignement.

[Ivan Posva, 2011-12-16 23:22:14]

http://codereview.chromium.org/8787012/diff/5001/vm/dart.cc
File vm/dart.cc (right):

http://codereview.chromium.org/8787012/diff/5001/vm/dart.cc#newcode8
vm/dart.cc:8: #include "vm/freelist.h"
On 2011/12/15 10:00:25, antonm wrote:
> nit: sorting

Done.

http://codereview.chromium.org/8787012/diff/5001/vm/freelist.cc
File vm/freelist.cc (right):

http://codereview.chromium.org/8787012/diff/5001/vm/freelist.cc#newcode21
vm/freelist.cc:21: reinterpret_cast<RawClass*>(calloc(1,
Class::InstanceSize()));
On 2011/12/15 10:00:25, antonm wrote:
> maybe should check the alignment of allocated data?  or allocate with the
proper
> alignement.

If calloc does not allocate on word boundaries I think there would be bigger
problems.

[Anton Muhin, 2011-12-19 15:31:26]

http://codereview.chromium.org/8787012/diff/5001/vm/freelist.cc
File vm/freelist.cc (right):

http://codereview.chromium.org/8787012/diff/5001/vm/freelist.cc#newcode21
vm/freelist.cc:21: reinterpret_cast<RawClass*>(calloc(1,
Class::InstanceSize()));
I am more concerned with the case when objects may (in the future) require
bigger alignment say to distinguish between new and old space objects---the
places that need adjustment might be tricky to spot.

On 2011/12/16 23:22:14, Ivan Posva wrote:
> On 2011/12/15 10:00:25, antonm wrote:
> > maybe should check the alignment of allocated data?  or allocate with the
> proper
> > alignement.
> 
> If calloc does not allocate on word boundaries I think there would be bigger
> problems.