Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8786016: Generate callbacks as typedefs. (Closed)

Created:
9 years ago by sra1
Modified:
9 years ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Generate callbacks as typedefs. IDL interfaces with the Callback extended attribute are emitted as typedefs instead of interfaces or classes. This brings the JS doms into line with the Dartium version. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2054

Patch Set 1 #

Patch Set 2 : add missing newline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -1370 lines) Patch
M client/dom/dom.dart View 8 chunks +0 lines, -21 lines 0 comments Download
M client/dom/frog/frog_dom.dart View 1 17 chunks +147 lines, -189 lines 0 comments Download
M client/dom/frog_dom.dart View 10 chunks +21 lines, -21 lines 0 comments Download
M client/dom/generated/monkey_dom.js View 25 chunks +0 lines, -210 lines 0 comments Download
D client/dom/generated/src/frog/AudioBufferCallback.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D client/dom/generated/src/frog/DatabaseCallback.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D client/dom/generated/src/frog/EntriesCallback.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D client/dom/generated/src/frog/EntryCallback.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D client/dom/generated/src/frog/ErrorCallback.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D client/dom/generated/src/frog/FileCallback.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D client/dom/generated/src/frog/FileSystemCallback.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D client/dom/generated/src/frog/FileWriterCallback.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D client/dom/generated/src/frog/MetadataCallback.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D client/dom/generated/src/frog/NavigatorUserMediaErrorCallback.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D client/dom/generated/src/frog/PositionCallback.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D client/dom/generated/src/frog/PositionErrorCallback.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D client/dom/generated/src/frog/SQLStatementCallback.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D client/dom/generated/src/frog/SQLStatementErrorCallback.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D client/dom/generated/src/frog/SQLTransactionCallback.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D client/dom/generated/src/frog/SQLTransactionErrorCallback.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D client/dom/generated/src/frog/SQLTransactionSyncCallback.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D client/dom/generated/src/frog/StorageInfoErrorCallback.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D client/dom/generated/src/frog/StorageInfoQuotaCallback.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D client/dom/generated/src/frog/StorageInfoUsageCallback.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D client/dom/generated/src/frog/StringCallback.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M client/dom/generated/src/interface/AudioBufferCallback.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M client/dom/generated/src/interface/DatabaseCallback.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M client/dom/generated/src/interface/EntriesCallback.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M client/dom/generated/src/interface/EntryCallback.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M client/dom/generated/src/interface/ErrorCallback.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M client/dom/generated/src/interface/FileCallback.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M client/dom/generated/src/interface/FileSystemCallback.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M client/dom/generated/src/interface/FileWriterCallback.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M client/dom/generated/src/interface/MetadataCallback.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M client/dom/generated/src/interface/NavigatorUserMediaErrorCallback.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M client/dom/generated/src/interface/PositionCallback.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M client/dom/generated/src/interface/PositionErrorCallback.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M client/dom/generated/src/interface/SQLStatementCallback.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M client/dom/generated/src/interface/SQLStatementErrorCallback.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M client/dom/generated/src/interface/SQLTransactionCallback.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M client/dom/generated/src/interface/SQLTransactionErrorCallback.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M client/dom/generated/src/interface/SQLTransactionSyncCallback.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M client/dom/generated/src/interface/StorageInfoErrorCallback.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M client/dom/generated/src/interface/StorageInfoQuotaCallback.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M client/dom/generated/src/interface/StorageInfoUsageCallback.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M client/dom/generated/src/interface/StringCallback.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
D client/dom/generated/src/wrapping/_AudioBufferCallbackWrappingImplementation.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D client/dom/generated/src/wrapping/_DatabaseCallbackWrappingImplementation.dart View 1 chunk +0 lines, -28 lines 0 comments Download
client/dom/generated/src/wrapping/_EntriesCallbackWrappingImplementation.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D client/dom/generated/src/wrapping/_EntryCallbackWrappingImplementation.dart View 1 chunk +0 lines, -20 lines 0 comments Download
client/dom/generated/src/wrapping/_ErrorCallbackWrappingImplementation.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D client/dom/generated/src/wrapping/_FileCallbackWrappingImplementation.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D client/dom/generated/src/wrapping/_FileSystemCallbackWrappingImplementation.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D client/dom/generated/src/wrapping/_FileWriterCallbackWrappingImplementation.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D client/dom/generated/src/wrapping/_MetadataCallbackWrappingImplementation.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D client/dom/generated/src/wrapping/_NavigatorUserMediaErrorCallbackWrappingImplementation.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D client/dom/generated/src/wrapping/_PositionCallbackWrappingImplementation.dart View 1 chunk +0 lines, -20 lines 0 comments Download
client/dom/generated/src/wrapping/_PositionErrorCallbackWrappingImplementation.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D client/dom/generated/src/wrapping/_SQLStatementCallbackWrappingImplementation.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D client/dom/generated/src/wrapping/_SQLStatementErrorCallbackWrappingImplementation.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D client/dom/generated/src/wrapping/_SQLTransactionCallbackWrappingImplementation.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D client/dom/generated/src/wrapping/_SQLTransactionErrorCallbackWrappingImplementation.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D client/dom/generated/src/wrapping/_SQLTransactionSyncCallbackWrappingImplementation.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D client/dom/generated/src/wrapping/_StorageInfoErrorCallbackWrappingImplementation.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D client/dom/generated/src/wrapping/_StorageInfoQuotaCallbackWrappingImplementation.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D client/dom/generated/src/wrapping/_StorageInfoUsageCallbackWrappingImplementation.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D client/dom/generated/src/wrapping/_StringCallbackWrappingImplementation.dart View 1 chunk +0 lines, -20 lines 0 comments Download
M client/dom/generated/wrapping_dom.js View 23 chunks +0 lines, -197 lines 0 comments Download
M client/dom/generated/wrapping_dom_externs.js View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/scripts/dartgenerator.py View 1 6 chunks +42 lines, -5 lines 0 comments Download
A + client/dom/scripts/template_callback.darttemplate View 1 chunk +0 lines, -4 lines 0 comments Download
M client/dom/wrapping_dom.dart View 8 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sra1
9 years ago (2011-12-03 06:07:13 UTC) #1 
tbr

Powered by Google App Engine
This is Rietveld 408576698