Issue 8784013: Fix CanvasPixelArray's operator[] for the wrapping js dom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8784013: Fix CanvasPixelArray's operator[] for the wrapping js dom (Closed)

Created:
9 years ago by sra1

Modified:
9 years ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix CanvasPixelArray's operator[] for the wrapping js dom The item() indexing accessor went away, so implement Dart indexing on top of JS indexing. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2055

Patch Set 1 #

Patch Set 2 : rerun #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+129 lines, -50 lines)			Patch
M	client/dom/frog/frog_dom.dart	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	client/dom/generated/monkey_dom.js	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	client/dom/generated/src/frog/CanvasPixelArray.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	client/dom/generated/src/interface/CanvasPixelArray.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_CanvasPixelArrayWrappingImplementation.dart	View		2 chunks	+4 lines, -9 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_HTMLCollectionWrappingImplementation.dart	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_MediaListWrappingImplementation.dart	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_NamedNodeMapWrappingImplementation.dart	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_NodeListWrappingImplementation.dart	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_StyleSheetListWrappingImplementation.dart	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	client/dom/generated/src/wrapping/_TouchListWrappingImplementation.dart	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	client/dom/generated/wrapping_dom.js	View		7 chunks	+58 lines, -2 lines	0 comments	Download
M	client/dom/generated/wrapping_dom_externs.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	client/dom/idl/dart/dart.idl	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	client/dom/scripts/dartgenerator.py	View		2 chunks	+54 lines, -9 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

tbr

Expand Messages | Collapse Messages