Issue 8784005: Build the sdk in PRODUCT_DIR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8784005: Build the sdk in PRODUCT_DIR. (Closed)

Created:
9 years ago by dgrove

Modified:
9 years ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Build the sdk in PRODUCT_DIR. Committed: https://code.google.com/p/dart/source/detail?r=2042

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	dart.gyp	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
	M	tools/create_sdk.py	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

9 years ago (2011-12-02 23:54:41 UTC) #2

lgtm with fix

http://codereview.chromium.org/8784005/diff/1/dart.gyp
File dart.gyp (right):

http://codereview.chromium.org/8784005/diff/1/dart.gyp#newcode52
dart.gyp:52: 'sdk',
add PRODUCT_DIR here too :)

Expand Messages | Collapse Messages