Issue 8776020: Ongoing renaming of type classes:

Issue 8776020: Ongoing renaming of type classes: (Closed)

Created:
9 years ago by srdjan

Modified:
9 years ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Ongoing renaming of type classes: TypeArguments -> AbstractTypeArguments TypeArray -> TypeArguments Committed: https://code.google.com/p/dart/source/detail?r=2002

Patch Set 3 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+429 lines, -381 lines)			Patch
M	runtime/lib/array.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/lib/double.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/error.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/lib/isolate.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/regexp.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/ast.h	View	5 chunks	+10 lines, -6 lines	0 comments	Download
M	runtime/vm/class_finalizer.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/class_finalizer.cc	View	7 chunks	+18 lines, -17 lines	0 comments	Download
M	runtime/vm/class_finalizer_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/code_generator.cc	View	10 chunks	+38 lines, -31 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	8 chunks	+15 lines, -13 lines	0 comments	Download
M	runtime/vm/object.h	View	32 chunks	+103 lines, -92 lines	0 comments	Download
M	runtime/vm/object.cc	View	57 chunks	+145 lines, -132 lines	0 comments	Download
M	runtime/vm/parser.h	View	4 chunks	+11 lines, -8 lines	0 comments	Download
M	runtime/vm/parser.cc	View	19 chunks	+32 lines, -27 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	8 chunks	+15 lines, -15 lines	0 comments	Download
M	runtime/vm/raw_object.cc	View	3 chunks	+11 lines, -10 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	5 chunks	+16 lines, -15 lines	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM http://codereview.chromium.org/8776020/diff/7001/runtime/vm/object.cc File runtime/vm/object.cc (right): http://codereview.chromium.org/8776020/diff/7001/runtime/vm/object.cc#newcode59 runtime/vm/object.cc:59: RawClass* Object::type_array_class_ = reinterpret_cast<RawClass*>(RAW_NULL); type_arguments_class_? http://codereview.chromium.org/8776020/diff/7001/runtime/vm/object.cc#newcode98 runtime/vm/object.cc:98: } ...

9 years ago (2011-12-01 22:20:16 UTC) #2

srdjan

9 years ago (2011-12-01 22:44:08 UTC) #3

Thanks!

http://codereview.chromium.org/8776020/diff/7001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

http://codereview.chromium.org/8776020/diff/7001/runtime/vm/object.cc#newcode59
runtime/vm/object.cc:59: RawClass* Object::type_array_class_ =
reinterpret_cast<RawClass*>(RAW_NULL);
On 2011/12/01 22:20:16, regis wrote:
> type_arguments_class_?

Done.

http://codereview.chromium.org/8776020/diff/7001/runtime/vm/object.cc#newcode98
runtime/vm/object.cc:98: } else if (raw_class == type_array_class()) {
On 2011/12/01 22:20:16, regis wrote:
> raw_class == type_arguments_class()?

Yes, forgot that one.

http://codereview.chromium.org/8776020/diff/7001/runtime/vm/object.cc#newcode144
runtime/vm/object.cc:144: case kTypeArgumentsClass: return type_array_class();
On 2011/12/01 22:20:16, regis wrote:
> return type_arguments_class()?

Done.

http://codereview.chromium.org/8776020/diff/7001/runtime/vm/object.cc#newcode291
runtime/vm/object.cc:291: type_array_class_ = cls.raw();
On 2011/12/01 22:20:16, regis wrote:
> ditto

Done.

http://codereview.chromium.org/8776020/diff/7001/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (right):

http://codereview.chromium.org/8776020/diff/7001/runtime/vm/raw_object.h#newc...
runtime/vm/raw_object.h:225: // TODO(srdjan): RawTypeArguments* interfaces_;  //
Array of Type.
On 2011/12/01 22:20:16, regis wrote:
> You want to change this later, I guess?

Yes.

http://codereview.chromium.org/8776020/diff/7001/runtime/vm/raw_object_snapsh...
File runtime/vm/raw_object_snapshot.cc (right):

http://codereview.chromium.org/8776020/diff/7001/runtime/vm/raw_object_snapsh...
runtime/vm/raw_object_snapshot.cc:311: TypeArguments& type_array =
TypeArguments::Handle(TypeArguments::New(len));
On 2011/12/01 22:20:16, regis wrote:
> type_array -> type_arguments

Done.

http://codereview.chromium.org/8776020/diff/7001/runtime/vm/raw_object_snapsh...
runtime/vm/raw_object_snapshot.cc:323: intptr_t object_id,
On 2011/12/01 22:20:16, regis wrote:
> indentation

Done.

http://codereview.chromium.org/8776020/diff/7001/runtime/vm/snapshot_test.cc
File runtime/vm/snapshot_test.cc (right):

http://codereview.chromium.org/8776020/diff/7001/runtime/vm/snapshot_test.cc#...
runtime/vm/snapshot_test.cc:172: writer.WriteObject(Object::type_array_class());
On 2011/12/01 22:20:16, regis wrote:
> type_arguments_class()

Done.

http://codereview.chromium.org/8776020/diff/7001/runtime/vm/snapshot_test.cc#...
runtime/vm/snapshot_test.cc:199: EXPECT(Object::type_array_class() ==
reader.ReadObject());
On 2011/12/01 22:20:16, regis wrote:
> ditto

Done.

Expand Messages | Collapse Messages