Issue 8776001: Fix HTTP sample implementation to actually wait for connections before attempting to write.

Issue 8776001: Fix HTTP sample implementation to actually wait for connections before attempting to write. (Closed)

Created:
9 years ago by Mads Ager (google)

Modified:
9 years ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix HTTP sample implementation to actually wait for connections before attempting to write. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1971

Patch Set 2 : Address comments. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -136 lines)			Patch
M	runtime/bin/eventhandler_linux.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/bin/socket_impl.dart	View		2 chunks	+2 lines, -12 lines	0 comments	Download
M	samples/chat/http.dart	View	1	1 chunk	+9 lines, -2 lines	0 comments	Download
M	samples/chat/http_impl.dart	View	1	4 chunks	+27 lines, -17 lines	0 comments	Download
M	samples/tests/samples/src/chat/ChatServerTest.dart	View		4 chunks	+45 lines, -32 lines	0 comments	Download
M	samples/tests/samples/src/chat/HttpTest.dart	View		3 chunks	+53 lines, -62 lines	0 comments	Download
M	tests/standalone/src/SocketExceptionTest.dart	View		1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

LGTM, with comments http://codereview.chromium.org/8776001/diff/1/samples/chat/http_impl.dart File samples/chat/http_impl.dart (right): http://codereview.chromium.org/8776001/diff/1/samples/chat/http_impl.dart#newcode1388 samples/chat/http_impl.dart:1388: You should also update http.dart where ...

9 years ago (2011-12-01 11:15:43 UTC) #2

Mads Ager (google)

9 years ago (2011-12-01 11:43:59 UTC) #3

http://codereview.chromium.org/8776001/diff/1/samples/chat/http_impl.dart
File samples/chat/http_impl.dart (right):

http://codereview.chromium.org/8776001/diff/1/samples/chat/http_impl.dart#new...
samples/chat/http_impl.dart:1388: 
On 2011/12/01 11:15:43, Søren Gjesse wrote:
> You should also update http.dart where this interface is documented.

Done.

http://codereview.chromium.org/8776001/diff/1/samples/chat/http_impl.dart#new...
samples/chat/http_impl.dart:1431: print('connect handler set');
On 2011/12/01 11:15:43, Søren Gjesse wrote:
> Remove print.

Done.

http://codereview.chromium.org/8776001/diff/1/samples/chat/http_impl.dart#new...
samples/chat/http_impl.dart:1433: print('connect handler');
On 2011/12/01 11:15:43, Søren Gjesse wrote:
> Ditto.

Done.

http://codereview.chromium.org/8776001/diff/1/samples/chat/http_impl.dart#new...
samples/chat/http_impl.dart:1496: var _openHandler;
On 2011/12/01 11:15:43, Søren Gjesse wrote:
> Remove empty line.

Done.

http://codereview.chromium.org/8776001/diff/1/tests/standalone/src/SocketExce...
File tests/standalone/src/SocketExceptionTest.dart (left):

http://codereview.chromium.org/8776001/diff/1/tests/standalone/src/SocketExce...
tests/standalone/src/SocketExceptionTest.dart:30: server.accept();
On 2011/12/01 11:15:43, Søren Gjesse wrote:
> Maybe put this back replacing accept with listen.

Listen is implicit. There is get port but that needs better error handling that
just returns zero at this point.

Expand Messages | Collapse Messages