Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 8775027: Frog now knows about the JS global object, and prevents name collisions with user code. (Closed)

Created:
9 years ago by Jennifer Messerly
Modified:
9 years ago
Reviewers:
jimhug, sra1
CC:
reviews_dartlang.org, Jacob
Visibility:
Public.

Description

Frog now knows about the JS global object, and prevents name collisions with user code. I wasn't sure how to update the IDL generator scripts, so I just hand edited the frog_dom file to add the "@". Fixes http://code.google.com/p/dart/issues/detail?id=637 Committed: https://code.google.com/p/dart/source/detail?r=1994

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -32 lines) Patch
M client/dom/frog/frog_dom.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/DOMWindow.dart View 1 chunk +2 lines, -1 line 0 comments Download
M frog/frogsh View 11 chunks +39 lines, -17 lines 0 comments Download
M frog/lib/corelib.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M frog/type.dart View 4 chunks +26 lines, -11 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Jennifer Messerly
tbr
9 years ago (2011-12-01 22:19:31 UTC) #1
jimhug
9 years ago (2011-12-14 22:17:59 UTC) #2
lgtm

http://codereview.chromium.org/8775027/diff/1/frog/type.dart
File frog/type.dart (right):

http://codereview.chromium.org/8775027/diff/1/frog/type.dart#newcode1223
frog/type.dart:1223: if (name.contains('@')) {
Random note: I wonder if we want to validate that there is only one of these and
signal at least a warning if there are multiples?

Powered by Google App Engine
This is Rietveld 408576698