Issue 8774039: Fix for Issue 622

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8774039: Fix for Issue 622 (Closed)

Created:
9 years ago by sra1

Modified:
9 years ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix for Issue 622 Inhibit parsing a lambda expression only at the top level of an initializer. Parse parenthesized expression explicitly to give better errors on malformed expressions: * No longer blindly accept "(x: a)" as (a). * In "(a, b)" complain about comma at the comma rather than the close paren. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2012

Patch Set 1 #

Patch Set 2 : comment #

Patch Set 3 : frogsh #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -41 lines)			Patch
M	frog/frogsh	View		13 chunks	+22 lines, -23 lines	0 comments	Download
M	frog/gen.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	frog/parser.dart	View	1	5 chunks	+19 lines, -16 lines	0 comments	Download
M	tests/language/language.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm. Lovely :)

Expand Messages | Collapse Messages