Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Issue 8773036: Make multi tests work with DartC. (Closed)

Created:
9 years ago by Mads Ager (google)
Modified:
9 years ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make multi tests work with DartC. The static type error annotations are in the multi-tests so that dartc can verify with the --fatal-type-errors flag that they are correctly caugth. Enqueue all tests from one configuration before moving on to the next to not start an overwhelming amount of directory listers. Simplify the setup of dartc batch runners. Simply restart with the right binary if there is a mismatch. With the new enqueueing switching happens at the right time and we can have as many dartc batch processors as we have cores. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2018

Patch Set 1 #

Patch Set 2 : Reworking #

Total comments: 6

Patch Set 3 : Address comments. #

Patch Set 4 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -64 lines) Patch
M tools/test.dart View 1 2 2 chunks +20 lines, -5 lines 0 comments Download
M tools/test-runtime.dart View 1 2 2 chunks +20 lines, -5 lines 0 comments Download
M tools/testing/dart/multitest.dart View 1 2 4 chunks +24 lines, -10 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 2 6 chunks +48 lines, -40 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 4 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
9 years ago (2011-12-02 12:39:05 UTC) #1
Bill Hesse
LGTM. http://codereview.chromium.org/8773036/diff/1004/tools/test-runtime.dart File tools/test-runtime.dart (right): http://codereview.chromium.org/8773036/diff/1004/tools/test-runtime.dart#newcode34 tools/test-runtime.dart:34: var currentConfiguration = 0; When I did the ...
9 years ago (2011-12-02 13:10:06 UTC) #2
Mads Ager (google)
9 years ago (2011-12-02 13:32:49 UTC) #3
http://codereview.chromium.org/8773036/diff/1004/tools/test-runtime.dart
File tools/test-runtime.dart (right):

http://codereview.chromium.org/8773036/diff/1004/tools/test-runtime.dart#newc...
tools/test-runtime.dart:34: var currentConfiguration = 0;
On 2011/12/02 13:10:06, Bill Hesse wrote:
> When I did the equivalent thing for serializing multitests, I used an iterator
> rather than a integer index.

Done.

http://codereview.chromium.org/8773036/diff/1004/tools/testing/dart/multitest...
File tools/testing/dart/multitest.dart (right):

http://codereview.chromium.org/8773036/diff/1004/tools/testing/dart/multitest...
tools/testing/dart/multitest.dart:189: // They should be registered in a
persistent list, so they can
On 2011/12/02 13:10:06, Bill Hesse wrote:
> Remove this TODO - we are not planning to delete generated tests.

Done.

http://codereview.chromium.org/8773036/diff/1004/tools/testing/dart/test_runn...
File tools/testing/dart/test_runner.dart (right):

http://codereview.chromium.org/8773036/diff/1004/tools/testing/dart/test_runn...
tools/testing/dart/test_runner.dart:328: !_enqueueMoreWork(this) &&
On 2011/12/02 13:10:06, Bill Hesse wrote:
> Should you comment here that enqueueMoreWork is an action, not just a test,
and
> you do it when all Listers are done, but that there may be tests in the queue?

> Or just note
> // Asks for more work when the current listers are done.

Yes, I should. Thanks.

Powered by Google App Engine
This is Rietveld 408576698