Issue 8773024: Mark frog DOMWindow as aliased with global scope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8773024: Mark frog DOMWindow as aliased with global scope. (Closed)

Created:
9 years ago by sra1

Modified:
9 years ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Mark frog DOMWindow as aliased with global scope. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2006

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -4 lines)			Patch
M	client/dom/frog/frog_dom.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	client/dom/generated/src/frog/DOMWindow.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	client/dom/scripts/dartgenerator.py	View	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

9 years ago (2011-12-02 00:25:23 UTC) #3

On 2011/12/02 00:24:48, John Messerly wrote:
> lgtm

Except now I know which file to change, next time I could fix something like
this myself...  Muhahaha :D

Expand Messages | Collapse Messages