Issue 8773006: Fork test scripts to support special runtime checkout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8773006: Fork test scripts to support special runtime checkout. (Closed)

Created:
9 years ago by Mads Ager (google)

Modified:
9 years ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/tools/

Visibility:
Public.

More Reviews

Description

Fork test scripts to support special runtime checkout. Deal with a couple of other issues in tests scripts also caused by having to support a separate runtime checkout. Committed: https://code.google.com/p/dart/source/detail?r=1977

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -8 lines)			Patch
A	test-runtime.dart	View		1 chunk	+43 lines, -0 lines	0 comments	Download
M	testing/dart/multitest.dart	View	1	1 chunk	+5 lines, -7 lines	0 comments	Download
M	testing/dart/test_progress.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	testing/dart/test_suite.dart	View		1 chunk	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

LGTM. http://codereview.chromium.org/8773006/diff/1/testing/dart/multitest.dart File testing/dart/multitest.dart (right): http://codereview.chromium.org/8773006/diff/1/testing/dart/multitest.dart#newcode192 testing/dart/multitest.dart:192: Expect.isTrue(split.removeLast() == 'src'); Even though Expect runs all ...

9 years ago (2011-12-01 12:59:34 UTC) #2

Mads Ager (google)

9 years ago (2011-12-01 13:02:04 UTC) #3

http://codereview.chromium.org/8773006/diff/1/testing/dart/multitest.dart
File testing/dart/multitest.dart (right):

http://codereview.chromium.org/8773006/diff/1/testing/dart/multitest.dart#new...
testing/dart/multitest.dart:192: Expect.isTrue(split.removeLast() == 'src');
On 2011/12/01 12:59:34, Bill Hesse wrote:
> Even though Expect runs all the time, not like assert, do you think that
people
> don't expect side effects in it?  They might skim over the Expect. functions,
> and not look for code in them.

Yeah, I probably should remove the last element on a separate line. Thanks.

http://codereview.chromium.org/8773006/diff/1/testing/dart/multitest.dart#new...
testing/dart/multitest.dart:200: 
On 2011/12/01 12:59:34, Bill Hesse wrote:
> Trailing blank line.

Done.

Expand Messages | Collapse Messages