Issue 8773005: Get rid of guessing the VM location in frog.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8773005: Get rid of guessing the VM location in frog.py. (Closed)

Created:
9 years ago by ngeoffray

Modified:
9 years ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Get rid of guessing the VM location in frog.py. Committed: https://code.google.com/p/dart/source/detail?r=1976

Patch Set 3 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -47 lines)			Patch
M	frog/dart-frog.gyp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	frog/frog.py	View	1 2	4 chunks	+23 lines, -30 lines	0 comments	Download
M	frog/scripts/bootstrap/frog_bootstrap_wrapper.py	View		1 chunk	+14 lines, -5 lines	0 comments	Download
M	frog/scripts/bootstrap/frog_wrapper.py	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	frog/scripts/bootstrap/frogsh_bootstrap_wrapper.py	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	tools/build.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! http://codereview.chromium.org/8773005/diff/1/frog/frog.py File frog/frog.py (right): http://codereview.chromium.org/8773005/diff/1/frog/frog.py#newcode40 frog/frog.py:40: def CheckUpdatedReleaseVersion(dart): This is a weird name. http://codereview.chromium.org/8773005/diff/1/frog/frog.py#newcode130 ...

9 years ago (2011-12-01 12:38:53 UTC) #2

ngeoffray

9 years ago (2011-12-01 12:53:33 UTC) #3

http://codereview.chromium.org/8773005/diff/1/frog/frog.py
File frog/frog.py (right):

http://codereview.chromium.org/8773005/diff/1/frog/frog.py#newcode40
frog/frog.py:40: def CheckUpdatedReleaseVersion(dart):
On 2011/12/01 12:38:54, ahe wrote:
> This is a weird name.

Yes, forgot to upload the last version. Renamed to GetReleaseVersion.

http://codereview.chromium.org/8773005/diff/1/frog/frog.py#newcode130
frog/frog.py:130: if os.path.basename(realpath(os.curdir)) == 'frog':
On 2011/12/01 12:38:54, ahe wrote:
> I'm not sure about this. I'll explain in person.

Thanks. Changed to use:
relpath(join(HOME, os.pardir, 'tools', 'build.py'))

Expand Messages | Collapse Messages

Issue 8773005: Get rid of guessing the VM location in frog.py. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages