Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 8772016: Refactor the gypi files to eliminate some redundancy. (Closed)

Created:
9 years ago by siva
Modified:
9 years ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Refactor the gypi files to eliminate some redundancy. Committed: https://code.google.com/p/dart/source/detail?r=1999

Patch Set 1 #

Total comments: 5

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -182 lines) Patch
M bin/bin.gypi View 1 6 chunks +13 lines, -172 lines 0 comments Download
A bin/builtin_sources.gypi View 1 1 chunk +76 lines, -0 lines 0 comments Download
M vm/vm.gypi View 1 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
9 years ago (2011-12-01 21:48:50 UTC) #1
Ivan Posva
LGTM after simplifications. -Ivan http://codereview.chromium.org/8772016/diff/1/bin/bin.gypi File bin/bin.gypi (left): http://codereview.chromium.org/8772016/diff/1/bin/bin.gypi#oldcode320 bin/bin.gypi:320: ['include', 'dart_api_impl.cc'], Great cleanup! http://codereview.chromium.org/8772016/diff/1/bin/bin.gypi ...
9 years ago (2011-12-01 22:19:31 UTC) #2
siva
9 years ago (2011-12-01 23:03:25 UTC) #3
http://codereview.chromium.org/8772016/diff/1/bin/bin.gypi
File bin/bin.gypi (right):

http://codereview.chromium.org/8772016/diff/1/bin/bin.gypi#newcode24
bin/bin.gypi:24: 'builtin.dart',
On 2011/12/01 22:19:31, Ivan Posva wrote:
> We should add those to the builtin_sources.gypi file instead.

Done.

http://codereview.chromium.org/8772016/diff/1/bin/bin.gypi#newcode80
bin/bin.gypi:80: 'bin_sources.gypi',
On 2011/12/01 22:19:31, Ivan Posva wrote:
> builtin_sources.gypi? bin_sources I would expect to contain main.cc and
similar.

Done.

Powered by Google App Engine
This is Rietveld 408576698