Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 8772008: Add line handler to string stream (Closed)

Created:
9 years ago by Søren Gjesse
Modified:
9 years ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add line handler to string stream This adds the line handler to the string stream to provide callbacks when a line is known to be available. This change also refactors parts of the string stream to avoid converting decoded char codes to a string before checking for line break sequences. With this change the string decoder tracks all line breaks. There is still room for improvement as e.g. the coping of the list of char codes when reading lines can be avoided by using anoher offset. R=ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2016

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -117 lines) Patch
M runtime/bin/input_stream.dart View 2 chunks +12 lines, -2 lines 0 comments Download
M runtime/bin/string_stream.dart View 12 chunks +117 lines, -112 lines 0 comments Download
M tests/standalone/src/StringStreamTest.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/status_file_parser.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
9 years ago (2011-12-02 10:06:22 UTC) #1
Mads Ager (google)
9 years ago (2011-12-02 11:07:50 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698