Allow single-dash options to be specified without a space before value.

Allow single-dash options to be specified without a space before value.

./tools/test.dart -mdebug,release

Make the patterns given to the test script more restrictive. A pattern
has to specify the test suite as the first component. The rest is used
as a pattern on all tests within that suite:

./tools/test.dart -mrelease leg co19/leg

will run the leg tests and the co19 tests that contains the substring
'leg' somewhere in the full path name of the test.

R=whesse@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=2014

[Bill Hesse, 2011-12-02 10:21:05]

I think we need to allow multiple patterns per suite:
test.dart standalone/Directory standalone/File.

http://codereview.chromium.org/8772007/diff/4001/tools/testing/dart/test_opti...
File tools/testing/dart/test_options.dart (right):

http://codereview.chromium.org/8772007/diff/4001/tools/testing/dart/test_opti...
tools/testing/dart/test_options.dart:132: name = arg;
Why isn't this an if ... else?
if (split == -1) {

} else {

}

http://codereview.chromium.org/8772007/diff/4001/tools/testing/dart/test_opti...
tools/testing/dart/test_options.dart:159: if (patterns == null) {
This is exactly
var patterns = configuration.putIfAbsent('selectors', ()=>[]);
, I think.

At least "new List()" should be replaced by [], I think, since [] does the same
thing as "new List()".

http://codereview.chromium.org/8772007/diff/4001/tools/testing/dart/test_opti...
tools/testing/dart/test_options.dart:233: List selectors =
configuration['selectors'];
If selectors will sometimes be a Map, this should be
var selectors = ...

http://codereview.chromium.org/8772007/diff/4001/tools/testing/dart/test_opti...
tools/testing/dart/test_options.dart:248: pattern = pattern.replaceAll('/',
'.*');
At least the "replaceAll('/'..." can go inside the if. Probably both
replaceAll()s.  What do you really want to do if the pattern has no slash in it?
 Will it be ignored silently unless it is a suite name?

http://codereview.chromium.org/8772007/diff/4001/tools/testing/dart/test_suit...
File tools/testing/dart/test_suite.dart (right):

http://codereview.chromium.org/8772007/diff/4001/tools/testing/dart/test_suit...
tools/testing/dart/test_suite.dart:72: // Only run the tests that match the
pattern. Use the name
Are you only allowing one pattern per suite?  What if I say
test.dart standalone/Black standalone/File ?

[Mads Ager (google), 2011-12-02 10:36:53]

I would like to see a need for having multiple patters for the same suite. I
have used the old test scripts for 5 years without needing it. :-)

http://codereview.chromium.org/8772007/diff/4001/tools/testing/dart/test_opti...
File tools/testing/dart/test_options.dart (right):

http://codereview.chromium.org/8772007/diff/4001/tools/testing/dart/test_opti...
tools/testing/dart/test_options.dart:132: name = arg;
On 2011/12/02 10:21:05, Bill Hesse wrote:
> Why isn't this an if ... else?
> if (split == -1) {
> 
> } else {
> 
> }

Done.

http://codereview.chromium.org/8772007/diff/4001/tools/testing/dart/test_opti...
tools/testing/dart/test_options.dart:159: if (patterns == null) {
On 2011/12/02 10:21:05, Bill Hesse wrote:
> This is exactly
> var patterns = configuration.putIfAbsent('selectors', ()=>[]);
> , I think.
> 
> At least "new List()" should be replaced by [], I think, since [] does the
same
> thing as "new List()".

Done.

http://codereview.chromium.org/8772007/diff/4001/tools/testing/dart/test_opti...
tools/testing/dart/test_options.dart:233: List selectors =
configuration['selectors'];
On 2011/12/02 10:21:05, Bill Hesse wrote:
> If selectors will sometimes be a Map, this should be
> var selectors = ...

Thanks! Done.

http://codereview.chromium.org/8772007/diff/4001/tools/testing/dart/test_opti...
tools/testing/dart/test_options.dart:248: pattern = pattern.replaceAll('/',
'.*');
On 2011/12/02 10:21:05, Bill Hesse wrote:
> At least the "replaceAll('/'..." can go inside the if. Probably both
> replaceAll()s.  What do you really want to do if the pattern has no slash in
it?
>  Will it be ignored silently unless it is a suite name?

Yes, the first component has to be a suite name and the pattern is ignored
otherwise. As with the current scripts.

http://codereview.chromium.org/8772007/diff/4001/tools/testing/dart/test_suit...
File tools/testing/dart/test_suite.dart (right):

http://codereview.chromium.org/8772007/diff/4001/tools/testing/dart/test_suit...
tools/testing/dart/test_suite.dart:72: // Only run the tests that match the
pattern. Use the name
On 2011/12/02 10:21:05, Bill Hesse wrote:
> Are you only allowing one pattern per suite?  What if I say
> test.dart standalone/Black standalone/File ?

If you want that you probably have a failure and want only one of them at a time
anyway. I don't think there will be a need for that.

[Bill Hesse, 2011-12-02 11:16:50]

LGTM.
Could we print messages in some of the unimplemented cases, like two patterns on
the same suite?

[Mads Ager (google), 2011-12-02 11:49:23]

Added warning print if multiple selectors are supplied for the same suite. It
should be trivial to add multiple patterns if we need it. Right now I want to
get the scripts completely working first. Thanks for your comments Bill.