Issue 8771039: Add #library directive to generate-stubs templates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8771039: Add #library directive to generate-stubs templates (Closed)

Created:
9 years ago by zundel

Modified:
9 years ago

Reviewers:
mmendez, Ben Laurie (Chromium)

CC:
reviews_dartlang.org, dgrove, Ivan Posva, mattsh

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add #library directive to generate-stubs templates Now the checked in version should match what is generated when running --component dartc tests Committed: https://code.google.com/p/dart/source/detail?r=2070

Patch Set 1 #

Patch Set 2 : Removed .dart suffix on library name #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
M	tests/stub-generator/src/MintMakerFullyIsolatedTest.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/stub-generator/src/MintMakerFullyIsolatedTest-generatedTest.dart	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/stub-generator/src/MintMakerPromiseWithStubsTest.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/stub-generator/src/MintMakerPromiseWithStubsTest-generatedTest.dart	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zundel

ref: http://codereview.chromium.org/8764019/ This should fix the #library directive in the -generatedTest.dart files so that it ...

9 years ago (2011-12-02 18:18:25 UTC) #1

mmendez

9 years ago (2011-12-05 13:50:47 UTC) #2

LGTM

The immediate change looks good.  I did not dig in to verify why this prevents
the modification.

On 2011/12/02 18:18:25, zundel wrote:
> ref: http://codereview.chromium.org/8764019/
> 
> This should fix the #library directive in the -generatedTest.dart files so
that
> it doesn't modify the checked in code each time we run dartc tests.

Expand Messages | Collapse Messages