Issue 8769039: Fix performance of readLine

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8769039: Fix performance of readLine (Closed)

Created:
9 years ago by Søren Gjesse

Modified:
9 years ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix performance of readLine Using getRange to chop off the front of the list of char codes for each line read was to slow. Use an offset into the list instead and throw away the list when all char codes have been read. R=ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2023

Patch Set 1 #

Patch Set 2 : Removed code in commetns #

Patch Set 3 : Fixed long line #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -12 lines)			Patch
	M	runtime/bin/string_stream.dart	View	1 2	4 chunks	+26 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages