Start resolving classes and default constructors.

Start resolving classes and default constructors.
Committed: https://code.google.com/p/dart/source/detail?r=2026

[ahe, 2011-12-02 11:27:41]

LGTM.

Don't forget the things about passing both node and element we talked about and
making partial class elements "ready".

http://codereview.chromium.org/8769012/diff/2002/frog/frogsh
File frog/frogsh (left):

http://codereview.chromium.org/8769012/diff/2002/frog/frogsh#oldcode6533
frog/frogsh:6533: return (($0 = this._nodes != null ? this._nodes :
const$209/*const EmptyLink<Node>()*/) == null ? null : $0.assert$Link_Node());
Long line ;-)

http://codereview.chromium.org/8769012/diff/2002/frog/leg/elements/elements.dart
File frog/leg/elements/elements.dart (right):

http://codereview.chromium.org/8769012/diff/2002/frog/leg/elements/elements.d...
frog/leg/elements/elements.dart:145: new Identifier(new StringToken(null, '',
null)),
Please add a constructor like:

new Identifier.synthetic('');

I'd like to keep the Token subclasses contained in the parser and scanner.

http://codereview.chromium.org/8769012/diff/2002/frog/leg/resolver.dart
File frog/leg/resolver.dart (right):

http://codereview.chromium.org/8769012/diff/2002/frog/leg/resolver.dart#newco...
frog/leg/resolver.dart:533: ClassElement cls = enclosingElement;
The word "enclosingElement" seems wrong in this context.

http://codereview.chromium.org/8769012/diff/2002/frog/leg/typechecker.dart
File frog/leg/typechecker.dart (right):

http://codereview.chromium.org/8769012/diff/2002/frog/leg/typechecker.dart#ne...
frog/leg/typechecker.dart:343: Type visitNewExpression(NewExpression node) {
Add todo.

[ngeoffray, 2011-12-02 14:44:54]

I had to make some changes in the listener because it was crashing frog with
NPEs and NSMEs. PTAL.

http://codereview.chromium.org/8769012/diff/2002/frog/leg/elements/elements.dart
File frog/leg/elements/elements.dart (right):

http://codereview.chromium.org/8769012/diff/2002/frog/leg/elements/elements.d...
frog/leg/elements/elements.dart:145: new Identifier(new StringToken(null, '',
null)),
On 2011/12/02 11:27:41, ahe wrote:
> Please add a constructor like:
> 
> new Identifier.synthetic('');
> 
> I'd like to keep the Token subclasses contained in the parser and scanner.

Done.

http://codereview.chromium.org/8769012/diff/2002/frog/leg/resolver.dart
File frog/leg/resolver.dart (right):

http://codereview.chromium.org/8769012/diff/2002/frog/leg/resolver.dart#newco...
frog/leg/resolver.dart:533: ClassElement cls = enclosingElement;
On 2011/12/02 11:27:41, ahe wrote:
> The word "enclosingElement" seems wrong in this context.

Changed to 'element'.

http://codereview.chromium.org/8769012/diff/2002/frog/leg/typechecker.dart
File frog/leg/typechecker.dart (right):

http://codereview.chromium.org/8769012/diff/2002/frog/leg/typechecker.dart#ne...
frog/leg/typechecker.dart:343: Type visitNewExpression(NewExpression node) {
On 2011/12/02 11:27:41, ahe wrote:
> Add todo.

Done.

[ngeoffray, 2011-12-02 15:34:57]

Changes to the listener removed. I have updated the status file.

[karlklose, 2011-12-05 14:54:55]

LGTM.

http://codereview.chromium.org/8769012/diff/2002/frog/leg/resolver.dart
File frog/leg/resolver.dart (right):

http://codereview.chromium.org/8769012/diff/2002/frog/leg/resolver.dart#newco...
frog/leg/resolver.dart:57: : this.compiler = compiler,
Extra space in the following two lines.