- "#library warning" fixit: Add #library where it could be expected.

- "#library warning" fixit: Add #library where it could be expected.
Committed: https://code.google.com/p/dart/source/detail?r=1968

[dgrove, 2011-12-01 05:53:48]

lgtm

[zundel, 2011-12-01 15:41:53]

http://codereview.chromium.org/8764019/diff/1/stub-generator/src/MintMakerFul...
File stub-generator/src/MintMakerFullyIsolatedTest-generatedTest.dart (right):

http://codereview.chromium.org/8764019/diff/1/stub-generator/src/MintMakerFul...
stub-generator/src/MintMakerFullyIsolatedTest-generatedTest.dart:7:
#library("MintMakerFullyIsolatedTest-generatedTest");
Since this file is generated, the generator (part of dartc) that makes this file
needs to be updated too.

[Ivan Posva, 2011-12-01 17:09:14]

http://codereview.chromium.org/8764019/diff/1/stub-generator/src/MintMakerFul...
File stub-generator/src/MintMakerFullyIsolatedTest-generatedTest.dart (right):

http://codereview.chromium.org/8764019/diff/1/stub-generator/src/MintMakerFul...
stub-generator/src/MintMakerFullyIsolatedTest-generatedTest.dart:7:
#library("MintMakerFullyIsolatedTest-generatedTest");
On 2011/12/01 15:41:54, zundel wrote:
> Since this file is generated, the generator (part of dartc) that makes this
file
> needs to be updated too.

I am sorry, I noticed that this file is generated. It is kind of obvious in the
name.

Unfortunately as this file is checked in, there is no way to ensure that the
current generator checked into the source tree would generate something that is
compatible, it might even have been generated with local changes in whoever's
checkout this came from. So I did the only thing that was available to me change
the file in place. Except of course deleting the generated file, which would be
the correct way of dealing with checked in generated source code.

[zundel, 2011-12-01 17:34:55]

On 2011/12/01 17:09:14, Ivan Posva wrote:
>
http://codereview.chromium.org/8764019/diff/1/stub-generator/src/MintMakerFul...
> File stub-generator/src/MintMakerFullyIsolatedTest-generatedTest.dart (right):
> 
>
http://codereview.chromium.org/8764019/diff/1/stub-generator/src/MintMakerFul...
> stub-generator/src/MintMakerFullyIsolatedTest-generatedTest.dart:7:
> #library("MintMakerFullyIsolatedTest-generatedTest");
> On 2011/12/01 15:41:54, zundel wrote:
> > Since this file is generated, the generator (part of dartc) that makes this
> file
> > needs to be updated too.
> 
> I am sorry, I noticed that this file is generated. It is kind of obvious in
the
> name.
> 
> Unfortunately as this file is checked in, there is no way to ensure that the
> current generator checked into the source tree would generate something that
is
> compatible, it might even have been generated with local changes in whoever's
> checkout this came from. So I did the only thing that was available to me
change
> the file in place. Except of course deleting the generated file, which would
be
> the correct way of dealing with checked in generated source code.

If you haven't created a bug already, could you create a bug and assign it to
me?