Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 8761011: Renaming type classes as discussed: (Closed)

Created:
9 years ago by srdjan
Modified:
9 years ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Renaming type classes as discussed: Type -> AbstractType ParameterizedType -> Type TODO: TypeArguments -> AbstractTypeArguments TypeArray -> TypeArguments Committed: https://code.google.com/p/dart/source/detail?r=1987

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Total comments: 12
Unified diffs Side-by-side diffs Delta from patch set Stats (+560 lines, -537 lines) Patch
M runtime/lib/error.cc View 1 2 3 5 chunks +6 lines, -5 lines 0 comments Download
M runtime/vm/ast.h View 4 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/ast_printer.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M runtime/vm/class_finalizer.h View 1 2 3 4 5 3 chunks +10 lines, -8 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 1 2 3 23 chunks +33 lines, -30 lines 0 comments Download
M runtime/vm/code_generator.cc View 1 2 3 4 5 3 chunks +4 lines, -5 lines 0 comments Download
M runtime/vm/code_generator_ia32.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/code_generator_ia32.cc View 1 2 3 4 5 7 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/flags.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 4 5 27 chunks +116 lines, -115 lines 6 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 63 chunks +197 lines, -194 lines 0 comments Download
M runtime/vm/object_store.h View 1 2 6 chunks +35 lines, -35 lines 0 comments Download
M runtime/vm/object_store.cc View 1 2 3 chunks +10 lines, -10 lines 0 comments Download
M runtime/vm/parser.h View 2 chunks +8 lines, -6 lines 3 comments Download
M runtime/vm/parser.cc View 1 2 3 4 5 52 chunks +78 lines, -67 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 11 chunks +16 lines, -16 lines 3 comments Download
M runtime/vm/raw_object.cc View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 2 3 4 5 4 chunks +9 lines, -10 lines 0 comments Download
M runtime/vm/scopes.h View 3 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/scopes.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
srdjan
9 years ago (2011-12-01 01:48:23 UTC) #1
regis
LGTM Thanks for doing this rename! Feel free to submit as is and keep the ...
9 years ago (2011-12-01 04:24:06 UTC) #2
srdjan
http://codereview.chromium.org/8761011/diff/1071/runtime/vm/object.h File runtime/vm/object.h (right): http://codereview.chromium.org/8761011/diff/1071/runtime/vm/object.h#newcode411 runtime/vm/object.h:411: RawAbstractType* SignatureType() const; On 2011/12/01 04:24:07, regis wrote: > ...
9 years ago (2011-12-01 17:48:42 UTC) #3
regis
9 years ago (2011-12-01 17:53:38 UTC) #4
http://codereview.chromium.org/8761011/diff/1071/runtime/vm/parser.h
File runtime/vm/parser.h (right):

http://codereview.chromium.org/8761011/diff/1071/runtime/vm/parser.h#newcode216
runtime/vm/parser.h:216: RawAbstractType* ParseInterface();
On 2011/12/01 17:48:42, srdjan wrote:
> On 2011/12/01 04:24:07, regis wrote:
> > This should always be a Type. Later cl.
> 
> This method does not exist, deleted. Maybe have ParseInterfaceList return
> TypeArguments?

Yes.

Powered by Google App Engine
This is Rietveld 408576698