Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8761004: Better fix for printing (after discussing it with Ivan and Regis) (Closed)

Created:
9 years ago by srdjan
Modified:
9 years ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Better fix for printing (after discussing it with Ivan and Regis) Committed: https://code.google.com/p/dart/source/detail?r=1952

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M runtime/vm/object.cc View 2 chunks +22 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
9 years ago (2011-11-30 22:45:43 UTC) #1
regis
LGTM http://codereview.chromium.org/8761004/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): http://codereview.chromium.org/8761004/diff/1/runtime/vm/object.cc#newcode2478 runtime/vm/object.cc:2478: // TypeArguments is an abstract class, however it ...
9 years ago (2011-11-30 22:53:29 UTC) #2
srdjan
9 years ago (2011-11-30 22:55:54 UTC) #3 
http://codereview.chromium.org/8761004/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

http://codereview.chromium.org/8761004/diff/1/runtime/vm/object.cc#newcode2478
runtime/vm/object.cc:2478: // TypeArguments is an abstract class, however it may
wrap a null.
On 2011/11/30 22:53:29, regis wrote:
> You can remove ", however it may wrap a null".

Done.

Powered by Google App Engine
This is Rietveld 408576698