Issue 8760015: Disable x64 disassembler under win32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8760015: Disable x64 disassembler under win32. (Closed)

Created:
9 years ago by regis

Modified:
9 years ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Disable x64 disassembler under win32. Add x64 assembler macros. Committed: https://code.google.com/p/dart/source/detail?r=1955

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -1 line)			Patch
M	runtime/vm/assembler_macros.h	View		1 chunk	+1 line, -1 line	0 comments	Download
A	runtime/vm/assembler_macros_x64.h	View		1 chunk	+40 lines, -0 lines	0 comments	Download
A	runtime/vm/assembler_macros_x64.cc	View	1	1 chunk	+58 lines, -0 lines	0 comments	Download
M	runtime/vm/disassembler_x64.cc	View		3 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM after comment is addressed. -Ivan http://codereview.chromium.org/8760015/diff/1/runtime/vm/assembler_macros_x64.cc File runtime/vm/assembler_macros_x64.cc (right): http://codereview.chromium.org/8760015/diff/1/runtime/vm/assembler_macros_x64.cc#newcode24 runtime/vm/assembler_macros_x64.cc:24: #if defined(DEBUG) This ...

9 years ago (2011-11-30 23:50:29 UTC) #2

regis

9 years ago (2011-12-01 00:08:50 UTC) #3

Thanks

http://codereview.chromium.org/8760015/diff/1/runtime/vm/assembler_macros_x64.cc
File runtime/vm/assembler_macros_x64.cc (right):

http://codereview.chromium.org/8760015/diff/1/runtime/vm/assembler_macros_x64...
runtime/vm/assembler_macros_x64.cc:24: #if defined(DEBUG)
On 2011/11/30 23:50:29, Ivan Posva wrote:
> This whole thing needs to start with:
> __ Untested("AssemblerMacros::TryAllocate");
> 
> Unless of course you tested this code already.

Done.

Expand Messages | Collapse Messages

Issue 8760015: Disable x64 disassembler under win32. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages