Issue 8758022: Custom native class spec for Console.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8758022: Custom native class spec for Console. (Closed)

Created:
9 years ago by sra1

Modified:
9 years ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Custom native class spec for Console. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2140

Patch Set 1 #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -28 lines)			Patch
	M	client/dom/generated/src/frog/Console.dart	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	client/dom/scripts/dartgenerator.py	View		9 chunks	+38 lines, -27 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

This still isn't working in FF. :-( Please see below. http://codereview.chromium.org/8758022/diff/1/client/dom/generated/src/frog/Console.dart File client/dom/generated/src/frog/Console.dart (right): http://codereview.chromium.org/8758022/diff/1/client/dom/generated/src/frog/Console.dart#newcode2 ...

9 years ago (2011-12-06 22:33:12 UTC) #2

Emily Fortuna

9 years ago (2011-12-06 23:23:00 UTC) #3

http://codereview.chromium.org/8758022/diff/1/client/dom/scripts/dartgenerato...
File client/dom/scripts/dartgenerator.py (left):

http://codereview.chromium.org/8758022/diff/1/client/dom/scripts/dartgenerato...
client/dom/scripts/dartgenerator.py:556:
self._StartGenerateJavaScriptMonkeyImpl(database, output_dir)
(thumbs up!)

Expand Messages | Collapse Messages