Issue 8758012: Port object tests to x64.

Issue 8758012: Port object tests to x64. (Closed)

Created:
9 years ago by regis

Modified:
9 years ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Port object tests to x64. Committed: https://code.google.com/p/dart/source/detail?r=1959

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -48 lines)			Patch
M	runtime/vm/assembler_x64.cc	View	1	3 chunks	+11 lines, -22 lines	0 comments	Download
M	runtime/vm/assembler_x64_test.cc	View		1 chunk	+25 lines, -0 lines	0 comments	Download
M	runtime/vm/constants_x64.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/object_arm_test.cc	View		1 chunk	+1 line, -8 lines	0 comments	Download
M	runtime/vm/object_ia32_test.cc	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/object_test.cc	View		4 chunks	+23 lines, -4 lines	0 comments	Download
M	runtime/vm/object_x64_test.cc	View	1	1 chunk	+15 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM http://codereview.chromium.org/8758012/diff/1/runtime/vm/assembler_x64.cc File runtime/vm/assembler_x64.cc (right): http://codereview.chromium.org/8758012/diff/1/runtime/vm/assembler_x64.cc#newcode1137 runtime/vm/assembler_x64.cc:1137: pushq(R11); Should we label R11 as scratch register? ...

9 years ago (2011-12-01 01:26:07 UTC) #2

regis

9 years ago (2011-12-01 01:42:04 UTC) #3

Thanks

http://codereview.chromium.org/8758012/diff/1/runtime/vm/assembler_x64.cc
File runtime/vm/assembler_x64.cc (right):

http://codereview.chromium.org/8758012/diff/1/runtime/vm/assembler_x64.cc#new...
runtime/vm/assembler_x64.cc:1137: pushq(R11);
On 2011/12/01 01:26:07, srdjan wrote:
> Should we label R11 as scratch register?

Defined alias TMP as R11.

http://codereview.chromium.org/8758012/diff/1/runtime/vm/assembler_x64_test.cc
File runtime/vm/assembler_x64_test.cc (right):

http://codereview.chromium.org/8758012/diff/1/runtime/vm/assembler_x64_test.c...
runtime/vm/assembler_x64_test.cc:1036: bool res =
reinterpret_cast<TestObjectCompare>(entry)();
On 2011/12/01 01:26:07, srdjan wrote:
> I would say "int res = ", or use true and false in Immediate(true).

Done.

http://codereview.chromium.org/8758012/diff/1/runtime/vm/object_x64_test.cc
File runtime/vm/object_x64_test.cc (right):

http://codereview.chromium.org/8758012/diff/1/runtime/vm/object_x64_test.cc#n...
runtime/vm/object_x64_test.cc:46: __ LoadObject(RAX, smi_object);
On 2011/12/01 01:26:07, srdjan wrote:
> Why can't you "LoadObject(RAX, smi)"?

Changed here and in object_ia32_test.cc, from where it was copied.

Expand Messages | Collapse Messages