Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 8758010: Create separate HTML pages for each type. (Closed)

Created:
9 years ago by Bob Nystrom
Modified:
9 years ago
CC:
reviews_dartlang.org, sethladd
Visibility:
Public.

Description

Create separate HTML pages for each type. This also writes everything to an index.html inside an appropriate directory. This keeps the URLs nice and pretty like: core_lib/String. The downside is that you'll need to run a little local web server to get them to be served up right instead of just opening them as files in your browser. Committed: https://code.google.com/p/dart/source/detail?r=2031

Patch Set 1 #

Patch Set 2 : Add option to make links use explicit /index.html. #

Patch Set 3 : Get rid of explicit link stuff and just use fixed URLs. #

Total comments: 25

Patch Set 4 : Respond to review. #

Patch Set 5 : Get dartdoc working with latest frog. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -105 lines) Patch
M utils/dartdoc/README.txt View 1 2 3 1 chunk +9 lines, -4 lines 0 comments Download
M utils/dartdoc/dartdoc View 1 2 chunks +8 lines, -3 lines 0 comments Download
M utils/dartdoc/dartdoc.dart View 1 2 3 4 15 chunks +176 lines, -98 lines 0 comments Download
A utils/dartdoc/test/dartdoc_tests.dart View 1 2 3 1 chunk +93 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Bob Nystrom
Before this, dartdoc generated docs for an entire library as one monolithic HTML file. This ...
9 years ago (2011-12-01 00:04:38 UTC) #1
Bob Nystrom
On 2011/12/01 00:04:38, Bob Nystrom wrote: > Before this, dartdoc generated docs for an entire ...
9 years ago (2011-12-01 02:17:05 UTC) #2
sethladd
mostly minor stuff. we can remove references to requiring a web server. http://codereview.chromium.org/8758010/diff/1004/utils/dartdoc/README.txt File utils/dartdoc/README.txt ...
9 years ago (2011-12-01 04:50:32 UTC) #3
pquitslund
LGTM (w/ a few typos and asides.) http://codereview.chromium.org/8758010/diff/1004/utils/dartdoc/README.txt File utils/dartdoc/README.txt (right): http://codereview.chromium.org/8758010/diff/1004/utils/dartdoc/README.txt#newcode19 utils/dartdoc/README.txt:19: To make ...
9 years ago (2011-12-01 23:29:54 UTC) #4
Siggi Cherem (dart-lang)
lgtm http://codereview.chromium.org/8758010/diff/1004/utils/dartdoc/dartdoc.dart File utils/dartdoc/dartdoc.dart (right): http://codereview.chromium.org/8758010/diff/1004/utils/dartdoc/dartdoc.dart#newcode215 utils/dartdoc/dartdoc.dart:215: int countOccurrences(String haystack, String needle) { nit: haystack, ...
9 years ago (2011-12-02 16:50:26 UTC) #5
Bob Nystrom
Thanks! http://codereview.chromium.org/8758010/diff/1004/utils/dartdoc/README.txt File utils/dartdoc/README.txt (right): http://codereview.chromium.org/8758010/diff/1004/utils/dartdoc/README.txt#newcode13 utils/dartdoc/README.txt:13: Then point your browser at `localhost:8000` to see ...
9 years ago (2011-12-02 19:40:55 UTC) #6
sethladd
9 years ago (2011-12-02 19:49:20 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698