Issue 8747023: Initial revision of assembler for x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8747023: Initial revision of assembler for x64. (Closed)

Created:
9 years ago by regis

Modified:
9 years ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Initial revision of assembler for x64. Committed: https://code.google.com/p/dart/source/detail?r=1951

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2958 lines, -33 lines)			Patch
M	runtime/vm/assembler_x64.h	View	1	3 chunks	+530 lines, -32 lines	0 comments	Download
A	runtime/vm/assembler_x64.cc	View		1 chunk	+1312 lines, -0 lines	0 comments	Download
A	runtime/vm/assembler_x64_test.cc	View		1 chunk	+1017 lines, -0 lines	0 comments	Download
M	runtime/vm/constants_x64.h	View	1	1 chunk	+96 lines, -0 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm I haven't gone though all the lines as this is from Parfait. http://codereview.chromium.org/8747023/diff/1/runtime/vm/assembler_x64.h File ...

9 years ago (2011-11-30 21:43:43 UTC) #2

regis

9 years ago (2011-11-30 22:02:09 UTC) #3

Thanks!

http://codereview.chromium.org/8747023/diff/1/runtime/vm/assembler_x64.h
File runtime/vm/assembler_x64.h (right):

http://codereview.chromium.org/8747023/diff/1/runtime/vm/assembler_x64.h#newc...
runtime/vm/assembler_x64.h:505: * Misc. functionality
On 2011/11/30 21:43:43, asiva wrote:
> missing '.'

Done.

Expand Messages | Collapse Messages