Issue 8742028: Use ParametrizedType instead of Type where appropriate. Expand ToCString of type related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8742028: Use ParametrizedType instead of Type where appropriate. Expand ToCString of type related classes. (Closed)

Created:
9 years ago by srdjan

Modified:
9 years ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Use ParametrizedType instead of Type where appropriate. Expand ToCString of type related classes. Do not instantiate abtract classes Type and TypeArguments (e.g., through Type::null()); Committed: https://code.google.com/p/dart/source/detail?r=1941

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+166 lines, -108 lines)			Patch
M	runtime/vm/class_finalizer.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/code_generator.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/object.h	View		5 chunks	+25 lines, -28 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	14 chunks	+72 lines, -28 lines	0 comments	Download
M	runtime/vm/object_store.h	View		6 chunks	+49 lines, -35 lines	0 comments	Download
M	runtime/vm/object_store.cc	View		3 chunks	+10 lines, -10 lines	0 comments	Download
M	runtime/vm/parser.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/snapshot.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages